release builds shouldn't fail when clobberer is not available

RESOLVED WONTFIX

Status

P3
normal
RESOLVED WONTFIX
6 years ago
3 years ago

People

(Reporter: rail, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Hit this in 17.0b3:

+ /tools/python/bin/python /builds/slave/rel-m-beta-psh-mrrrs/scripts/scripts/release/../..//clobberer/clobberer.py -s scripts -s buildprops.json http://clobberer.pvt.build.mozilla.org/always_clobber.php release-mozilla-beta release-mozilla-beta-push_to_mirrors rel-m-beta-psh-mrrrs bld-lion-r5-088 http://buildbot-master30.srv.releng.scl3.mozilla.com:8001/
Checking clobber URL: http://clobberer.pvt.build.mozilla.org/always_clobber.php?master=http%3A%2F%2Fbuildbot-master30.srv.releng.scl3.mozilla.com%3A8001%2F&slave=bld-lion-r5-088&builddir=rel-m-beta-psh-mrrrs&branch=release-mozilla-beta&buildername=release-mozilla-beta-push_to_mirrors
Error contacting server
program finished with exit code 1

always_clobber.php is a dirty hack, we should get rid of it.
[00:16:41]	<Callek>	rail: I'd even go as far as to say, if clobberer can't be reached, we clobber the build we're attempting and move on
[00:17:00]	<Callek>	though we could also just fail the build early too -- since clobberer down is indicative of another problem, likely
[00:17:44]	<rail>	Callek: hmm, can you add that as a bug comment please?
[00:17:51]	<Callek>	sure
I may well be that clobberer being down is indicative of wider problems...Still, it is inefficient to be contacting a remote service that tells us the same thing every time we ask.
(In reply to Chris AtLee [:catlee] from comment #2)
> I may well be that clobberer being down is indicative of wider
> problems...Still, it is inefficient to be contacting a remote service that
> tells us the same thing every time we ask.

Agreed. If we always want to clobber release builds, we should just do it and get clobberer out of this. This isn't very hard to do. We need to add a clobber option to ScriptFactory, ReleaseUpdatesFactory, and maybe a couple of other places.
Priority: -- → P3
(Assignee)

Updated

5 years ago
Product: mozilla.org → Release Engineering
Release builds are going away with release promotion!
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.