Closed Bug 804916 Opened 12 years ago Closed 12 years ago

[email] Remove UI for Undo email move and delete

Categories

(Firefox OS Graveyard :: Gaia::E-Mail, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::E-Mail
Platform:
x86
macOS
Type:
defect

Tracking

(blocking-basecamp:+)

Status:
VERIFIED FIXED
Project Flags:
blocking-basecamp +

People

(Reporter: doliver, Assigned: steveck)

References

Details

Attachments

(2 files)

https://github.com/mozilla-b2g/gaia/pull/5826
356 bytes, text/html
asuth
: review+
Details
delete undo button removal patch
356 bytes, text/html
asuth
: review+
Details 
Undo of moves is not yet implemented and is being moved out of V1. The current confirmation banner presents an Undo option, so that button just needs to be removed.
See Also: → 804904
blocking-basecamp: ? → +
Assignee: nobody → schung

        Attachment #675488 -
        Flags: review?(dkuo)

        Attachment #675488 -
        Flags: review?(bugmail)
Priority: -- → P1

    
    

    
  
Comment on attachment 675488 [details]
https://github.com/mozilla-b2g/gaia/pull/5826

r=asuth on https://github.com/mozilla-b2g/gaia/pull/5826

merged into gaia/master as:
https://github.com/mozilla-b2g/gaia/commit/b8bae22a80a964ec3f0700cc7b60964d68037476

This does not close the bug because we actually want undo hidden for deletion as well.  Amending subject momentarily...

        Attachment #675488 -
        Flags: review?(dkuo)

        Attachment #675488 -
        Flags: review?(bugmail)

        Attachment #675488 -
        Flags: review+

    
    

    
  
Steve, please provide a patch to also collapse the undo button for deletion.  Let's not remove the DOM node from the UI entirely since we will want to be able to undo things eventually.
Status: NEW → ASSIGNED
Summary: [email] Remove UI for Undo email move → [email] Remove UI for Undo email move and delete

    
    

    
  


  

        Attachment #676549 -
        Flags: review?(bugmail)

        Attachment #676549 -
        Flags: review?(bugmail) → review+

    
    

    
  
Thanks for the follow-up patch.  I hit the merge button, so this landed on gaia/master with:
https://github.com/mozilla-b2g/gaia/commit/9572efd699fbb19f7519fa953117c4ba5f90fafa

Marking fixed.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED

    
    

    
  
verified
build info
2012-11-01
gaia master : 6947eedbf2d368e02c1f4dcea6f1f9d958446bb7
gecko : 5a551f7362fffdb3e6471ce59874c404c74913a1
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: