804963 - [Bug Homescreen] Sometimes the pulsating effect disappear in the dock in edit mode

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Cristian Rodriguez (:crdlc)]

Enter in edit mode, move the dock, sometimes the pulsating effect of icons disappear

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/5978

fixed

Comment 2

[Mike Connor [:mconnor]]

Polish issue, not blocking per blocker triage.

Comment 3

[Cristian Rodriguez (:crdlc)]

ok thanks Mike. If Vivien can review it he could merge because this problem was introduced removing bouncing animations from dock and it was blocking-basecamp+. The bug is not a blocker but is ugly and I have the fix already implemented :) Thanks a lot

Comment 4

[Cristian Rodriguez (:crdlc)]

Comment on attachment 674602 [details]
https://github.com/mozilla-b2g/gaia/pull/5978

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 5

[Cristian Rodriguez (:crdlc)]

Andreas as far as I remember you reviewed my last bug in order to remove the bouncing animation from dock. This one is related to that. Thanks

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 674602 [details]
https://github.com/mozilla-b2g/gaia/pull/5978

Followup of a blocking-bsaecamp. r+a=me.

Comment 7

[Cristian Rodriguez (:crdlc)]

Thanks Vivien

Comment 8

[Rebecca Billings [:rbillings]]

Verified on 10/31 otoro us build - able to move dock and switch between home screen pages within edit mode.