Last Comment Bug 804990 - very long data urls break inline history
: very long data urls break inline history
Classification: Other
Component: Extensions: InlineHistory (show other bugs)
: Production
: x86 Mac OS X
-- normal (vote)
: ---
Assigned To: Byron Jones ‹:glob›
Depends on: 772359
  Show dependency treegraph
Reported: 2012-10-24 05:38 PDT by Byron Jones ‹:glob›
Modified: 2013-09-18 07:39 PDT (History)
4 users (show)
See Also:
Due Date:
QA Whiteboard:
Iteration: ---
Points: ---


Description User image Byron Jones ‹:glob› 2012-10-24 05:38:27 PDT
very long data urls break inline history, currently in two ways.

first, the split url isn't joined when displayed, resulting in multiple inline history lines.

second, very long urls are displayed in full, resulting in ugliness.

see bug 804961 for an example.
Comment 1 User image Byron Jones ‹:glob› 2012-10-24 05:45:34 PDT
oops, bug 804946
Comment 2 User image Byron Jones ‹:glob› 2012-10-24 07:12:29 PDT
the first half will be fixed by bug 772359
Comment 3 User image Jared Wein [:jaws] (please needinfo? me) 2012-10-24 10:58:15 PDT
Should we also block URLs over some length, like 2048 characters?
Comment 4 User image Byron Jones ‹:glob› 2013-09-18 07:39:38 PDT
Committing to: bzr+ssh://
modified extensions/InlineHistory/
modified extensions/InlineHistory/template/en/default/hook/bug/comments-aftercomments.html.tmpl
Committed revision 9020.

Note You need to log in before you can comment on or make changes to this bug.