Progressive tile painting causes reftests to fail

RESOLVED FIXED

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: cwiiis, Assigned: cwiiis)

Tracking

Trunk
ARM
Android
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
Enabling progressive rendering causes permanent orange on some tests in R1 and R4.
(Assignee)

Comment 1

6 years ago
Created attachment 674659 [details] [diff] [review]
Disable progressive tile rendering with a shadow target

Got r=bgirard on IRC, assuming this fixes the problem.

When a shadow target is set, the layer manager waits until transactions aren't repeated, but it doesn't expect paints to be cancelled. As other problems are also likely to crop up from the testing framework not really expecting asynchronous drawing, disable progressive tile rendering with a shadow target set, for now.
Attachment #674659 - Flags: review+
(Assignee)

Comment 3

6 years ago
hmm, not green - R4 still fails. It just looks like it needs fuzzing, the output is near identical, but it looks like an offset may have changed slightly. Given that progressive rendering isn't used drawing reftests, I'm not sure what path has changed that there'd be a difference at all...

I'll go over this code after fixing bug 805028.
(Assignee)

Comment 4

6 years ago
Pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/6376bf9b9cc6

Consensus is to fuzz R4 - will do a little bit more experimentation, but will go ahead and do that if it leads to nothing.
Whiteboard: [leave-open]
(Assignee)

Comment 5

6 years ago
Created attachment 675185 [details] [diff] [review]
Fuzz gradient-live tests for Android

Add the necessary amount of fuzzing to make this test pass. Given the problems these tests have had in the past (bug 653481 and bug 696674), none of which actually appear to have been actively fixed, I'm not inclined to investigate this too much further.
Attachment #675185 - Flags: review?(jwatt)
Attachment #675185 - Flags: review?(jwatt) → review+
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [leave-open]
You need to log in before you can comment on or make changes to this bug.