Closed
Bug 805054
Opened 13 years ago
Closed 13 years ago
Bind the virtualenv version Marionetts uses in venv_test.sh to a fixed release
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(firefox18 fixed, firefox19 fixed)
RESOLVED
FIXED
mozilla19
People
(Reporter: whimboo, Assigned: whimboo)
Details
(Whiteboard: [qa?])
Attachments
(1 file)
|
1.61 KB,
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/venv_test.sh
> curl https://raw.github.com/pypa/virtualenv/develop/virtualenv.py | ${PYTHON} - $VENV_DIR
This can cause problems if there are checkins into virtualenv which are broken. So we really should depend on a released version of virtualenv instead of develop.
|
Assignee | |
Comment 1•13 years ago
|
||
Pushed to try to ensure all tests are working:
https://tbpl.mozilla.org/?tree=Try&rev=7fbab008911a
|
|
Assignee | |
Comment 2•13 years ago
|
||
All looks good with this patch on the tryserver build.
|
||
Comment 3•13 years ago
|
||
Comment on attachment 681431 [details] [diff] [review]
Patch v1
Review of attachment 681431 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm
Attachment #681431 -
Flags: review?(jgriffin) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Whiteboard: [automation-needed-in-aurora]
|
||
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
|
|
||
Comment 6•13 years ago
|
||
status-firefox18:
--- → fixed
status-firefox19:
--- → fixed
Whiteboard: [automation-needed-in-aurora]
|
|
||
Comment 7•13 years ago
|
||
Is there any specific verification qa help with for this bug fix?
Whiteboard: [qa?]
|
||
Updated•3 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•