805097 - [socorro-crashstats] Blank entry (literally) on the topchangers page

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

STR:

1. Load http://crash-stats-new-dev.allizom.org/topchangers/products/Firefox/versions/19.0a1
2. Look at the entry for Rank of 32

Actual:

It's blank...

Comment 1

[Robert Helmer [:rhelmer]]

Interesting, the equiv page on c-s-d doesn't show up:
https://crash-stats-dev.allizom.org/products/Firefox/versions/19.0a1/topchangers

Comment 2

[Robert Helmer [:rhelmer]]

(In reply to Robert Helmer [:rhelmer] from comment #1)
> Interesting, the equiv page on c-s-d doesn't show up:
> https://crash-stats-dev.allizom.org/products/Firefox/versions/19.0a1/
> topchangers

Oops page shows up, I mean equiv row of course

Comment 3

[Robert Helmer [:rhelmer]]

I don't see it now :/ please reopen if it shows up again

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified WFM; I scoured, and couldn't find this either with a few products and even more versions, each.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Seeing this again on http://crash-stats-new-dev.allizom.org/topchangers/products/Thunderbird/versions/15.0.1?days=28; see screenshot.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

Comment 7

[Robert Helmer [:rhelmer]]

Hmm ok caught it, so this one is coming through with an empty signature:

{u'count': 82, u'mac_count': 0, u'content_count': 0, u'first_report': u'2011-01-01', u'startup_percent': 0.0975609756097561, u'currentRank': 194, u'previousRank': 275, u'first_report_exact': u'2011-01-01 00:01:22', u'versions': u'3.0.11, 3.1.6, 3.1.7, 3.1.13, 3.1.17, 3.1.20, 5.0, 6.0b1, 6.0b2, 6.0b3, 6.0(beta), 6.0, 6.0.1(beta), 6.0.1, 6.0.2(beta), 6.0.2, 7.0b1, 7.0b2, 7.0b3, 7.0(beta), 7.0, 7.0.1(beta), 7.0.1, 8.0b1, 8.0b2, 8.0b3, 8.0b4, 8.0b5, 8.0(beta), 8.0, 9.0a1, 9.0a2, 9.0b5, 9.0, 9.0.1, 10.0a1, 10.0b3, 10.0, 10.0.1, 10.0.1esr, 10.0.2, 10.0.2esr, 10.0.5esr, 11.0a2, 11.0, 11.0.1, 12.0, 12.0.1, 13.0b4, 13.0, 13.0.1, 14.0b2, 14.0, 15.0, 15.0.1, 16.0b4, 16.0, 16.0.1', u'percentOfTotal': 0.000330196466897804, u'win_count': 0, u'previousPercentOfTotal': 0.000214831207351385, u'changeInPercentOfTotal': 0.000115365259546419, u'linux_count': 0, u'hang_count': 0, u'signature': u'', u'versions_count': 58, u'changeInRank': 81, u'plugin_count': 0}

I suspect that the old app just filters this out.

Comment 8

[[DEACTIVATED] Adrian Gaudebert]

For what it's worth, on /query a null signature is being displayed as "(null signature)" and a link to http://code.google.com/p/socorro/wiki/NullOrEmptySignatures

Comment 9

[Robert Helmer [:rhelmer]]

r? https://github.com/mozilla/socorro-crashstats/pull/268

Comment 10

[Robert Helmer [:rhelmer]]

(In reply to Adrian Gaudebert [:adrian] from comment #8)
> For what it's worth, on /query a null signature is being displayed as "(null
> signature)" and a link to
> http://code.google.com/p/socorro/wiki/NullOrEmptySignatures

Thanks.. that kind of makes more sense but does not seem to be what the old site does, just ignores it :/ I'll file a bug to change it, not blocking staging.

Comment 11

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/06955ba48aa1c4e67aa986f910b785020f001d77
bug 805097 - filter out blank signatures in topchangers

https://github.com/mozilla/socorro-crashstats/commit/1258eb8ca15191a085aaae85fd5fb9670732445a
Merge pull request #268 from rhelmer/bug805097-blank-signature-in-topchangers

bug 805097 - filter out blank signatures in topchangers

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Thx; went through a bunch of both Thunderbird and Firefox topchangers reports, and didn't encounter this again.

Verified FIXED.