805118 - If machineNumber() doesn't recognise a Mochitest buildername, don't just display as ""

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Ed Morley [:emorley]]

On cedar, the buildernames for mochitests have been changed from the current trunk value of form:
  Rev3 Fedora 12x64 mozilla-inbound debug test mochitests-3/5
to:
  Rev3 Fedora 12x64 cedar debug test mochitests-3

This means they are currently showing up as blank spaces on TBPL, due to:

   920     var linkText = machine.type == "Mochitest" && onlyNumber ?
   921       machine.machineNumber() :
   922       Config.resultNames[machine.type] + machine.machineNumber();
   923     if (this._machineResultHasNotes(machineResult))
   924       linkText += '*';
   925     return '<a' +
   926       (machineResult.isFinished() ? ' href="' + machineResult.briefLogURL + '"' : '') +
   927       ' resultID="' + machineResult.runID + '"' +
   928       (machineResult.runID == this._activeResult ? ' active="true"' : '') +
   929       ' class="machineResult ' + machineResult.state +
   930         (machineResult.runID in this._selectedBuilds ? ' selected' : '') +
   931       '"' +
   932       ' title="' + this._resultTitle(machineResult) + '"' +
   933       '>' + linkText + '</a>';

The regex for the buildername has been fixed in bug 786314, but we should still make sure that mochitests where the buildername was returned as "" (by Data.js' machineNumber()) show up as 'M'.

Comment 1

[Ed Morley [:emorley]]

Attachment: Patch v1

Display mochitests whose part name/number wasn't recognised as "M" rather than "".

Comment 2

[Ed Morley [:emorley]]

Attachment: Screenshot: before

Comment 3

[Ed Morley [:emorley]]

Attachment: Screenshot: after

Comment 4

[Ed Morley [:emorley]]

Thank you :-)

https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/d710b5c067be