Closed
Bug 805118
Opened 13 years ago
Closed 13 years ago
If machineNumber() doesn't recognise a Mochitest buildername, don't just display as ""
Categories
(Tree Management Graveyard :: TBPL, defect)
Tree Management Graveyard
TBPL
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(3 files)
On cedar, the buildernames for mochitests have been changed from the current trunk value of form:
Rev3 Fedora 12x64 mozilla-inbound debug test mochitests-3/5
to:
Rev3 Fedora 12x64 cedar debug test mochitests-3
This means they are currently showing up as blank spaces on TBPL, due to:
920 var linkText = machine.type == "Mochitest" && onlyNumber ?
921 machine.machineNumber() :
922 Config.resultNames[machine.type] + machine.machineNumber();
923 if (this._machineResultHasNotes(machineResult))
924 linkText += '*';
925 return '<a' +
926 (machineResult.isFinished() ? ' href="' + machineResult.briefLogURL + '"' : '') +
927 ' resultID="' + machineResult.runID + '"' +
928 (machineResult.runID == this._activeResult ? ' active="true"' : '') +
929 ' class="machineResult ' + machineResult.state +
930 (machineResult.runID in this._selectedBuilds ? ' selected' : '') +
931 '"' +
932 ' title="' + this._resultTitle(machineResult) + '"' +
933 '>' + linkText + '</a>';
The regex for the buildername has been fixed in bug 786314, but we should still make sure that mochitests where the buildername was returned as "" (by Data.js' machineNumber()) show up as 'M'.
Assignee | ||
Comment 1•13 years ago
|
||
Display mochitests whose part name/number wasn't recognised as "M" rather than "".
Attachment #674764 -
Flags: review?(arpad.borsos)
Assignee | ||
Comment 2•13 years ago
|
||
Assignee | ||
Comment 3•13 years ago
|
||
Updated•13 years ago
|
Attachment #674764 -
Flags: review?(arpad.borsos) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Assignee | ||
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: Webtools → Tree Management
Updated•10 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•