805171 - Abouthome is doing database queries on the main thread

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[Wesley Johnston (:wesj)]

Not sure why this cursor has to be found on the ui thread. Looking into it, but this query takes about 1000ms on my device (with little to no history).

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch 1

I know sriram did a lot of perf work. Any idea why this is here?

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch 2/2

I also noticed that we spend about 500ms inflating stuff (on the UI thread) when we load about:home. I think we can avoid that by doing this.

Comment 3

[Wesley Johnston (:wesj)]

Comment on attachment 674815 [details] [diff] [review]
Patch 1

Crud. You're right this is fine I think.

Comment 4

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 674817 [details] [diff] [review]
Patch 2/2

Review of attachment 674817 [details] [diff] [review]:
-----------------------------------------------------------------

This would avoid re-inflation on rotate.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Wes - What's the status here?

Comment 6

[Wesley Johnston (:wesj)]

I think this was invalid. Closing.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

According to the main thread stack in bug 856585 comment 0, there is still database activity on the main thread from about:home.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #7)
> According to the main thread stack in bug 856585 comment 0, there is still
> database activity on the main thread from about:home.

I can open a new bug for that. I am working on a patch.