805178 - Device Storage - Application Permissions do not match that of the Permission Matrix

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect, P1)

Comment 1

[[:fabrice] Fabrice Desré]

Attachment: patch

I also added the missing device-storage:sdcard permission.

Comment 2

[Doug Turner (:dougt)]

Fabrice, I love you... but... the fix that I am working on does 3 things:

1) fixes device storage so that it knows about app status
2) adds a bunch of tests to ensure that we don't do anything terrible stupid (like expose device storage to the wrong appstatus)
3) that's it.

I suppose I should just create a new bug who's task is to do the above.

Comment 3

[Doug Turner (:dougt)]

See bug 805322.

Comment 4

[Doug Turner (:dougt)]

Comment on attachment 674870 [details] [diff] [review]
patch

Review of attachment 674870 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine, but it will not work until I am done with the other bug.

Comment 5

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/mozilla-inbound/rev/487f6dcb3d85

Comment 6

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/82ce45ddd3ea for bc failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=16501551&tree=Mozilla-Inbound

Comment 7

[[:fabrice] Fabrice Desré]

pushed with test fixed (green try run at https://tbpl.mozilla.org/?tree=Try&rev=24d81f5ef421)
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a2f469390e2

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7a2f469390e2

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bfc03cb0e941

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/10310453f2c2