Closed Bug 805202 Opened 7 years ago Closed 7 years ago

depend on gio 2.20 for --enable-gio builds and directly call g_app_info_get_commandline()

Categories

(Core :: XPCOM, defect)

x86
OpenBSD
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: gaston, Assigned: gaston)

Details

Attachments

(1 file, 1 obsolete file)

Per bug 803815 comment 5, not depending on glib 2.20 back in 2009 when the dlopen() code was written, but those days it should be safe enough, and simplifies the code.
Comment on attachment 674839 [details] [diff] [review]
Depend on gio 2.20, directly call g_app_info_get_commandline

Untested, but you get the idea.. i'll do some real testing tmrw.
Attachment #674839 - Flags: review?(karlt)
Attachment #674839 - Attachment is patch: true
Comment on attachment 674839 [details] [diff] [review]
Depend on gio 2.20, directly call g_app_info_get_commandline

The docs say that g_app_info_get_commandline can return NULL, so I think we still need the null check on the const char * return value.

Otherwise, looks good thanks.
Attachment #674839 - Flags: review?(karlt)
Attachment #674839 - Flags: review-
Attachment #674839 - Flags: feedback+
Damn right, totally overlooked that.
Assignee: nobody → landry
Attachment #674839 - Attachment is obsolete: true
Attachment #675251 - Flags: review?(karlt)
Attachment #675251 - Flags: review?(karlt) → review+
https://tbpl.mozilla.org/?tree=Try&rev=428f53b1197f

just to be on the safe side, since i have no idea what gio version is installed on the linux builders...
https://hg.mozilla.org/mozilla-central/rev/a4e9d21b8ca8
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.