805207 - ClearOnShutdown shouldn't have a static destructor

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Justin Lebar (not reading bugmail)]

> extern LinkedList<ShutdownObserver> sShutdownObservers;

This is problematic because it's a static destructor, which slows us down.

It's also problematic now that bug 803688 has landed, because when we do ContentChild::QuickExit(), we run sShutdownObservers's destructor, which causes us to assert.

https://tbpl.mozilla.org/php/getParsedLog.php?id=16428594&tree=Mozilla-Inbound#error0

Comment 1

[Justin Lebar (not reading bugmail)]

Attachment: Bug 805207 - Remove static destructor from ClearOnShutdown.

Comment 2

[Justin Lebar (not reading bugmail)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/303e6cbbb932

Comment 3

[Justin Lebar (not reading bugmail)]

And bustage fix for C++ unit tests on Windows/Mac:

https://hg.mozilla.org/integration/mozilla-inbound/rev/918caab17da2

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/303e6cbbb932
https://hg.mozilla.org/mozilla-central/rev/918caab17da2