Closed Bug 805207 Opened 7 years ago Closed 7 years ago

ClearOnShutdown shouldn't have a static destructor

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)

References

Details

Attachments

(1 file)

> extern LinkedList<ShutdownObserver> sShutdownObservers;

This is problematic because it's a static destructor, which slows us down.

It's also problematic now that bug 803688 has landed, because when we do ContentChild::QuickExit(), we run sShutdownObservers's destructor, which causes us to assert.

https://tbpl.mozilla.org/php/getParsedLog.php?id=16428594&tree=Mozilla-Inbound#error0
Assignee: nobody → justin.lebar+bug
Blocks: 803688
Attachment #674873 - Flags: review?(benjamin) → review+
And bustage fix for C++ unit tests on Windows/Mac:

https://hg.mozilla.org/integration/mozilla-inbound/rev/918caab17da2
https://hg.mozilla.org/mozilla-central/rev/303e6cbbb932
https://hg.mozilla.org/mozilla-central/rev/918caab17da2
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.