Closed
Bug 805207
Opened 12 years ago
Closed 12 years ago
ClearOnShutdown shouldn't have a static destructor
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)
References
Details
Attachments
(1 file)
2.67 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
> extern LinkedList<ShutdownObserver> sShutdownObservers; This is problematic because it's a static destructor, which slows us down. It's also problematic now that bug 803688 has landed, because when we do ContentChild::QuickExit(), we run sShutdownObservers's destructor, which causes us to assert. https://tbpl.mozilla.org/php/getParsedLog.php?id=16428594&tree=Mozilla-Inbound#error0
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → justin.lebar+bug
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #674873 -
Flags: review?(benjamin)
Updated•12 years ago
|
Attachment #674873 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/303e6cbbb932
Assignee | ||
Comment 3•12 years ago
|
||
And bustage fix for C++ unit tests on Windows/Mac: https://hg.mozilla.org/integration/mozilla-inbound/rev/918caab17da2
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/303e6cbbb932 https://hg.mozilla.org/mozilla-central/rev/918caab17da2
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in
before you can comment on or make changes to this bug.
Description
•