805222 - Change some usages of GetFunctionId to GetFunctionDisplayId

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Tom S [:evilpie]]

Attachment: v1

Using the inferred name for functions makes reading Components.stack a lot prettier and allows use to omit useless names for functions that could usually stay anonymous in JavaScript.

Comment 1

[Tom S [:evilpie]]

Attachment: v2

I had to fix two "console.trace()" tests to make them pass.
Please check if the test change is okay for you, assuming you are the right person to ask.

Comment 2

[Bobby Holley (:bholley)]

Comment on attachment 675164 [details] [diff] [review]
v2

rs=me

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 675164 [details] [diff] [review]
v2

Review of attachment 675164 [details] [diff] [review]:
-----------------------------------------------------------------

yup. Thanks for catching those test files.

Comment 4

[Rob Campbell [:rc] (:robcee)]

I believe this is good to land. Adding checkin-needed.

Comment 5

[Tom S [:evilpie]]

Ah right, thank you. Just came back from the US and forgot about this.
http://hg.mozilla.org/integration/mozilla-inbound/rev/4b5c3e84739b

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4b5c3e84739b