805233 - error: addon-sdk: TEST FAILED: test-windows.testTrackWindows (failure)

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This showed up on Linux64 only after bug 803065 landed:

error: addon-sdk: TEST FAILED: test-windows.testTrackWindows (failure)
error: addon-sdk: fail: correct activate and deactivate sequence ("global activate -1,global activate -1,global activate -1,global activate -1,activate 0,global activate 0,deactivate 0,global deactivate 0,activate 1,global activate 1,deactivate 1,global deactivate 1,activate 2,global activate 2" != "activate 0,global activate 0,deactivate 0,global deactivate 0,activate 1,global activate 1,deactivate 1,global deactivate 1,activate 2,global activate 2")
info: addon-sdk: Traceback (most recent call last):
  File "resource://72191bc7-1570-4a0b-a06d-3ec7a8b2ea64-at-jetpack/addon-sdk/lib/sdk/deprecated/errors.js", line 23, in null
    return callback.apply(this, arguments);
  File "resource://72191bc7-1570-4a0b-a06d-3ec7a8b2ea64-at-jetpack/addon-sdk/lib/sdk/deprecated/window-utils.js", line 123, in observe
    this._unregWindow(window);
  File "resource://72191bc7-1570-4a0b-a06d-3ec7a8b2ea64-at-jetpack/addon-sdk/lib/sdk/deprecated/window-utils.js", line 98, in _unregWindow
    this._delegate.onUntrack(window);
  File "resource://72191bc7-1570-4a0b-a06d-3ec7a8b2ea64-at-jetpack/addon-sdk/lib/sdk/windows/firefox.js", line 236, in _onUntrack
    window.destroy();
  File "resource://72191bc7-1570-4a0b-a06d-3ec7a8b2ea64-at-jetpack/addon-sdk/lib/sdk/windows/firefox.js", line 73, in null
    destroy: function () this._onUnload(),
  File "resource://72191bc7-1570-4a0b-a06d-3ec7a8b2ea64-at-jetpack/addon-sdk/lib/sdk/windows/firefox.js", line 89, in null
    this._emitOnObject(browserWindows, 'close', this._public);
  File "resource://72191bc7-1570-4a0b-a06d-3ec7a8b2ea64-at-jetpack/addon-sdk/lib/sdk/deprecated/events.js", line 153, in _emitOnObject
    listener.apply(targetObj, params);
  File "resource://72191bc7-1570-4a0b-a06d-3ec7a8b2ea64-at-jetpack/addon-sdk/tests/windows/test-firefox-windows.js", line 302, in shutdown
    "correct activate and deactivate sequence")
  File "resource://72191bc7-1570-4a0b-a06d-3ec7a8b2ea64-at-jetpack/addon-sdk/lib/sdk/deprecated/unit-test.js", line 168, in assertEqual
    this.fail(message);
  File "resource://72191bc7-1570-4a0b-a06d-3ec7a8b2ea64-at-jetpack/addon-sdk/lib/sdk/deprecated/unit-test.js", line 75, in fail
    this.console.trace();


Erik said he's just going to back out the breaking change for now so he can deal with more important issues today, but I'm filing to track it when it relands.

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

should be fixed by https://github.com/mozilla/addon-sdk/commit/6fa7e7b9b07c768637a5df106d83f9b245f5c743