Closed
Bug 805266
Opened 8 years ago
Closed 8 years ago
Avoid extra make pass in mime/public
Categories
(MailNews Core :: Build Config, defect)
MailNews Core
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 19.0
People
(Reporter: neil, Assigned: neil)
Details
Attachments
(1 file)
801 bytes,
patch
|
rain1
:
review+
|
Details | Diff | Splinter Review |
nsIMsgQuoteListener inherits from nsIMimeStreamConverterListener. When we parallelised the build we added an extra pass to export nsIMimeStreamConverterListener before we built in compose. However these days we can fix the problem by setting XPIDL_FLAGS instead.
Assignee | ||
Comment 1•8 years ago
|
||
Comment 2•8 years ago
|
||
Comment on attachment 674897 [details] [diff] [review] Proposed patch Makes sense. r+ assuming it builds.
Attachment #674897 -
Flags: review?(sid.bugzilla) → review+
Comment 3•8 years ago
|
||
Try run for 032cdf627968 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=032cdf627968 Results (out of 9 total builds): success: 7 failure: 2 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/neil@parkwaycc.co.uk-032cdf627968
Assignee | ||
Comment 4•8 years ago
|
||
(In reply to Mozilla RelEng Bot from comment #3) > Try run for 032cdf627968 is complete. > Detailed breakdown of the results available here: > https://tbpl.mozilla.org/?tree=Try&rev=032cdf627968 Oops ;-) > Results (out of 9 total builds): > success: 7 > failure: 2 Bah, stupid build system, runs tests even though I didn't want any, then reports test failure as red... the other build failure was a missing source file which was weird, but unrelated.
Assignee | ||
Comment 5•8 years ago
|
||
Pushed comm-central changeset 77155457d4b0.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Target Milestone: --- → Thunderbird 19.0
You need to log in
before you can comment on or make changes to this bug.
Description
•