Avoid extra make pass in mime/public

RESOLVED FIXED in Thunderbird 19.0

Status

MailNews Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

Trunk
Thunderbird 19.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
nsIMsgQuoteListener inherits from nsIMimeStreamConverterListener. When we parallelised the build we added an extra pass to export nsIMimeStreamConverterListener before we built in compose. However these days we can fix the problem by setting XPIDL_FLAGS instead.
(Assignee)

Comment 1

5 years ago
Created attachment 674897 [details] [diff] [review]
Proposed patch
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #674897 - Flags: review?(sid.bugzilla)
Comment on attachment 674897 [details] [diff] [review]
Proposed patch

Makes sense. r+ assuming it builds.
Attachment #674897 - Flags: review?(sid.bugzilla) → review+

Comment 3

5 years ago
Try run for 032cdf627968 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=032cdf627968
Results (out of 9 total builds):
    success: 7
    failure: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/neil@parkwaycc.co.uk-032cdf627968
(Assignee)

Comment 4

5 years ago
(In reply to Mozilla RelEng Bot from comment #3)
> Try run for 032cdf627968 is complete.
> Detailed breakdown of the results available here:
>     https://tbpl.mozilla.org/?tree=Try&rev=032cdf627968
Oops ;-)

> Results (out of 9 total builds):
>     success: 7
>     failure: 2
Bah, stupid build system, runs tests even though I didn't want any, then reports test failure as red... the other build failure was a missing source file which was weird, but unrelated.
(Assignee)

Comment 5

5 years ago
Pushed comm-central changeset 77155457d4b0.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
You need to log in before you can comment on or make changes to this bug.