Closed
Bug 805297
Opened 13 years ago
Closed 13 years ago
Marionette doesn't recognize relative test path from current working directory
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(firefox18 fixed, firefox19 fixed)
RESOLVED
FIXED
mozilla19
People
(Reporter: whimboo, Assigned: whimboo)
Details
Attachments
(1 file)
|
2.39 KB,
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
When I was running the first B2G Marionette tests via ./test.sh (B2G repository) I have noticed that Marionette does not work when you specify a relative path to the test or the manifest. Reason is that we do a couple of cwd changes in the venv_test.sh script to get everything setup and installed, and the relative path of the test gets added to the marionette folder. But it should be from the cwd of the user.
The patch I have works fine and leaves the tree green:
https://tbpl.mozilla.org/?tree=Try&rev=cc7dfeeaea34
But sadly we have a strange delay in getting the development version of Marionette installed. I will investigate that before uploading a patch.
| Assignee | ||
Comment 1•13 years ago
|
||
With this patch we will ensure to keep the CWD of the user when the script is called via B2G/test.sh. As noted in the patch there is one exception when we have to change the CWD to install Marionette in develop mode. Not doing that will cause a hang.
Comment 2•13 years ago
|
||
Comment on attachment 675265 [details] [diff] [review]
Patch v1
Looks good, thanks!
Attachment #675265 -
Flags: review?(jgriffin) → review+
| Assignee | ||
Comment 3•13 years ago
|
||
Target Milestone: --- → mozilla19
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Updated•13 years ago
|
Whiteboard: [automation-needed-in-aurora]
Comment 5•13 years ago
|
||
Comment 6•13 years ago
|
||
status-firefox18:
--- → fixed
status-firefox19:
--- → fixed
Whiteboard: [automation-needed-in-aurora]
Updated•3 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•