Closed Bug 805297 Opened 7 years ago Closed 7 years ago

Marionette doesn't recognize relative test path from current working directory

Categories

(Testing :: Marionette, defect)

defect
Not set

Tracking

(firefox18 fixed, firefox19 fixed)

RESOLVED FIXED
mozilla19
Tracking Status
firefox18 --- fixed
firefox19 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

Details

Attachments

(1 file)

When I was running the first B2G Marionette tests via ./test.sh (B2G repository) I have noticed that Marionette does not work when you specify a relative path to the test or the manifest. Reason is that we do a couple of cwd changes in the venv_test.sh script to get everything setup and installed, and the relative path of the test gets added to the marionette folder. But it should be from the cwd of the user.

The patch I have works fine and leaves the tree green:
https://tbpl.mozilla.org/?tree=Try&rev=cc7dfeeaea34

But sadly we have a strange delay in getting the development version of Marionette installed. I will investigate that before uploading a patch.
Attached patch Patch v1Splinter Review
With this patch we will ensure to keep the CWD of the user when the script is called via B2G/test.sh. As noted in the patch there is one exception when we have to change the CWD to install Marionette in develop mode. Not doing that will cause a hang.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Attachment #675265 - Flags: review?(jgriffin)
Comment on attachment 675265 [details] [diff] [review]
Patch v1

Looks good, thanks!
Attachment #675265 - Flags: review?(jgriffin) → review+
https://hg.mozilla.org/mozilla-central/rev/48d71f461152
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [automation-needed-in-aurora]
You need to log in before you can comment on or make changes to this bug.