805337 - [email] implement synchronization activity indicator

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect, P1)

Description

[Dylan Oliver [:doliver]]

User story requirement: 
As a user I want to see an activity animation and a counter of loaded messages when I select the option to load more messages from the server, so that I know the action is being taken

Comment 1

[Dylan Oliver [:doliver]]

asuth says: Activity animation happens, progress bar still needs implementation.

Comment 2

[Alex Keybl [:akeybl]]

We're marking this bug with the C1 milestone since it follows the criteria of "unfinished feature work" (see https://etherpad.mozilla.org/b2g-convergence-schedule).

If this work is not finished by Nov19, this bug will need an exception and will be called out at the upcoming Exec Review.

Comment 3

[Dietrich Ayala (:dietrich)]

No comments for a while - any update here Andrew?

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

(In reply to Dietrich Ayala (:dietrich) from comment #3)
> No comments for a while - any update here Andrew?

From https://bugzilla.mozilla.org/show_bug.cgi?id=800449#c10:
> The pull request attaching extension is dying, but the not-quite-ready pull
> request is here:
> https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/82
> 
> It also covers bug 805337 and bug 799063 because they're all inter-related.

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6484

Pointer to Github pull-request

Comment 6

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 685311 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6484

This has some new strings in it plus a fix for the cleanup pass where the lack of an l10n note probably left things unclear.

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 685311 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6484

r=squib from github and IRC

Comment 8

[Andrew Sutherland [:asuth] (he/him)]

I've landed this despite the outstanding string review request because there's no avoiding the need for the strings for our UX and this was a held-over C1.  stas, feel free to reopen if you would like changes to the string-touching pieces of this patch.

landed on gaia-email-libs-and-more/master (review was tracked on bug 800449):
https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/82

landed on gaia/master:
https://github.com/mozilla-b2g/gaia/pull/6484

Comment 9

[Staś Małolepszy :stas]

Comment on attachment 685311 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6484

Hey Andrew, thanks for landing this, it looks good!

Comment 10

[Nick Davidson]

related to Bug 824072 - [B2G][Email] Activity message DOES NOT show the number of messages loaded and did not changed indicating that the download has completed.

According to comment by Andrew Sutherland - "We no longer desire to show any counts" when loading  messages from server.

Comment 11

[Mila Davydova]

Unagi, build ID 20130103070201

There is no "load more messages from the server" option displayed. User is unable to continue to load messages from the server to observe the activity animation indicator.
New bug # 826466 is created, regarding this issue.

Comment 12

[Mila Davydova]

This issue does not reproduce on Unagi, Build ID: 20130112070202

Comment 13

[Tracy Walker [:tracy]]

this is covered in moztrap by test case https://moztrap.mozilla.org/manage/case/3342/