Last Comment Bug 805446 - <Delete> key in Feed Subscriptions window does not work as expected
: <Delete> key in Feed Subscriptions window does not work as expected
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Feed Reader (show other bugs)
: 16
: All All
: -- normal (vote)
: Thunderbird 19.0
Assigned To: alta88
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-25 08:19 PDT by trinsnet
Modified: 2012-11-08 10:50 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (3.14 KB, patch)
2012-10-25 11:28 PDT, alta88
mconley: review+
Details | Diff | Splinter Review

Description trinsnet 2012-10-25 08:19:52 PDT
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20100101 Firefox/16.0
Build ID: 20121010144125

Steps to reproduce:

Go to Account settings > Account Actions > Add Other Account > choose Blogs and News Feeds > Next, Next, Finish with defaults > choose to Manage Subscriptions in Blogs and News Feeds account > enter a valid feed URL
(e.g. http://rss.slashdot.org/Slashdot/slashdot )
You are now in the Feed Subscriptions window:
Attempt to edit the Title field by clicking on it and pressing <Delete> to clear the title.


Actual results:

You are prompted if you would like to unsubscribe from the feed. This dialog should not appear in this situation.
If you say 'no' to the dialog box, the title field is then cleared as it should be.


Expected results:

The title field should be cleared and you should be able to type a new title for the feed.

You can work around this by closing the Feed Subscription window and renaming the subscription by right clicking on it.

Either the title field in Feed Subscription window should not be editable or the <delete> key should not attempt to delete the feed when editing the title field.
Comment 1 alta88 2012-10-25 11:28:56 PDT
Created attachment 675217 [details] [diff] [review]
patch


yeah, the del key is meant only if the feed is selected *and* focused in the tree..

patch also includes ensuring valid feed urls yet with 0 items cases are handled.
Comment 2 Mike Conley (:mconley) - (Needinfo me!) 2012-11-07 18:03:29 PST
Comment on attachment 675217 [details] [diff] [review]
patch

Review of attachment 675217 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good - thanks alta88!
Comment 3 Ryan VanderMeulen [:RyanVM] 2012-11-08 10:50:57 PST
https://hg.mozilla.org/comm-central/rev/a5bf6bfcce18

Note You need to log in before you can comment on or make changes to this bug.