Closed Bug 805456 Opened 7 years ago Closed 7 years ago

GCC 4.7 build warning: nsJISx4501LineBreaker.cpp:548:21: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]

Categories

(Core :: Internationalization, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file, 1 obsolete file)

{
/mozilla/intl/lwbrk/src/nsJISx4501LineBreaker.cpp:548:21: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
}

It's warning about the first check in this assertion:
> 547   PRUnichar GetCharAt(uint32_t aIndex) {
> 548     NS_ASSERTION(0 <= aIndex && aIndex < mLength, "Out of range!");
https://mxr.mozilla.org/mozilla-central/source/intl/lwbrk/src/nsJISx4501LineBreaker.cpp#547

from this cset:
https://hg.mozilla.org/mozilla-central/diff/579d8ab862ee/intl/lwbrk/src/nsJISx4501LineBreaker.cpp#l1.687
Attached patch fix (obsolete) — Splinter Review
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #675146 - Flags: review?(masayuki)
Noted r+ in commit message, so that I can mark this as checkin-needed.
Attachment #675146 - Attachment is obsolete: true
Attachment #675195 - Flags: review+
(In reply to Daniel Holbert [:dholbert] from comment #2)
> Noted r+ in commit message, so that I can mark this as checkin-needed.

You don't need to do that. I usually qref -e everything I land anyway :)

https://hg.mozilla.org/integration/mozilla-inbound/rev/04602cf8bff7
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/04602cf8bff7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.