805456 - GCC 4.7 build warning: nsJISx4501LineBreaker.cpp:548:21: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Daniel Holbert [:dholbert]]

{
/mozilla/intl/lwbrk/src/nsJISx4501LineBreaker.cpp:548:21: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
}

It's warning about the first check in this assertion:
> 547   PRUnichar GetCharAt(uint32_t aIndex) {
> 548     NS_ASSERTION(0 <= aIndex && aIndex < mLength, "Out of range!");
https://mxr.mozilla.org/mozilla-central/source/intl/lwbrk/src/nsJISx4501LineBreaker.cpp#547

from this cset:
https://hg.mozilla.org/mozilla-central/diff/579d8ab862ee/intl/lwbrk/src/nsJISx4501LineBreaker.cpp#l1.687

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix for landing [r=masayuki]

Noted r+ in commit message, so that I can mark this as checkin-needed.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

(In reply to Daniel Holbert [:dholbert] from comment #2)
> Noted r+ in commit message, so that I can mark this as checkin-needed.

You don't need to do that. I usually qref -e everything I land anyway :)

https://hg.mozilla.org/integration/mozilla-inbound/rev/04602cf8bff7

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/04602cf8bff7