Closed
Bug 805492
Opened 12 years ago
Closed 12 years ago
The new decompiler is hitting an AssertNoGC()
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: terrence, Assigned: terrence)
Details
Attachments
(1 file)
5.14 KB,
patch
|
sfink
:
review+
jorendorff
:
feedback+
|
Details | Diff | Splinter Review |
Jason hit this failing stack: https://gist.github.com/3954084 Looking into it now.
Assignee | ||
Comment 1•12 years ago
|
||
This should either fix the problem or make the assert happen closer to the problem.
Attachment #675202 -
Flags: feedback?(jorendorff)
Updated•12 years ago
|
Attachment #675202 -
Flags: feedback?(jorendorff) → feedback+
Comment 2•12 years ago
|
||
Comment on attachment 675202 [details] [diff] [review] v0 Review of attachment 675202 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jsopcode.cpp @@ +328,3 @@ > { > + AssertCanGC(); > + RootedScript script(cx, scriptArg); This can just take a HandleScript now, no?
Assignee | ||
Comment 3•12 years ago
|
||
No, it's part of the API.
Assignee | ||
Updated•12 years ago
|
Attachment #675202 -
Flags: review?(sphink)
Comment 4•12 years ago
|
||
Comment on attachment 675202 [details] [diff] [review] v0 Review of attachment 675202 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jsopcode.cpp @@ +328,3 @@ > { > + AssertCanGC(); > + RootedScript script(cx, scriptArg); Apparently, the JSScript* is for calling from gdb, where constructing a Handle might be annoying. And given that this isn't exposed in any header file, that seems valid.
Attachment #675202 -
Flags: review?(sphink) → review+
Assignee | ||
Comment 5•12 years ago
|
||
Green try at: https://tbpl.mozilla.org/?tree=Try&rev=6c9f78601e21 Pushed at: https://hg.mozilla.org/integration/mozilla-inbound/rev/a3709787bfca
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a3709787bfca
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in
before you can comment on or make changes to this bug.
Description
•