The new decompiler is hitting an AssertNoGC()

RESOLVED FIXED in mozilla19

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla19
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Jason hit this failing stack: https://gist.github.com/3954084

Looking into it now.
(Assignee)

Comment 1

6 years ago
Created attachment 675202 [details] [diff] [review]
v0

This should either fix the problem or make the assert happen closer to the problem.
Attachment #675202 - Flags: feedback?(jorendorff)
Attachment #675202 - Flags: feedback?(jorendorff) → feedback+
Comment on attachment 675202 [details] [diff] [review]
v0

Review of attachment 675202 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsopcode.cpp
@@ +328,3 @@
>  {
> +    AssertCanGC();
> +    RootedScript script(cx, scriptArg);

This can just take a HandleScript now, no?
(Assignee)

Comment 3

6 years ago
No, it's part of the API.
(Assignee)

Updated

6 years ago
Attachment #675202 - Flags: review?(sphink)
Comment on attachment 675202 [details] [diff] [review]
v0

Review of attachment 675202 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsopcode.cpp
@@ +328,3 @@
>  {
> +    AssertCanGC();
> +    RootedScript script(cx, scriptArg);

Apparently, the JSScript* is for calling from gdb, where constructing a Handle might be annoying. And given that this isn't exposed in any header file, that seems valid.
Attachment #675202 - Flags: review?(sphink) → review+
https://hg.mozilla.org/mozilla-central/rev/a3709787bfca
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.