Closed Bug 805532 Opened 12 years ago Closed 12 years ago

[gallery] share activity does not expose the filename of the shared file

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: asuth, Unassigned)

References

Details

In bug 799827 I am completing the e-mail app's share implementation.  E-mail attachments are capable of having their filenames exposed.  As it stands, I need to make up a filename for the file we attach.

It would be great if we could just use the existing file name unless there is a privacy reason to not do that.  Since I don't believe we are censoring any EDID metadata, I am supposing the reason the filename is not exposed is because the other consumers don't care.

I propose that in parallel to the list of urls we also have a list of filenames.  I believe even after the blobification happens on bug 782766 this will still be necessary.  (File would work, but the patches there are clearly for Blob and DeviceStorage uses Blob, so, that doesn't seem to be in the cards.)

I can provide the patch for this.  I would arbitrarily choose "filenames" to be the parallel list of filenames (mainly because urls is lowercase and "filename" in open is all lowercase).
Flags: needinfo?(dflanagan)
I was thinking we'd get the names when we switched to blobs.  But you're probably right that the conversion from files to blobs would probably strip that info.

I was thinking of adding this for Ian's bluetooth file transfer as well. He doesn't think he'll need it, but it seems like it might be nice to have.

I agree with everything you've proposed, and will be happy to review the patch.
Flags: needinfo?(dflanagan)
Pull request was, r=djf:
https://github.com/mozilla-b2g/gaia/pull/6012

Landed on gaia/master with merge on the authority of bug 799827 of which this forms a separable sub-change:
https://github.com/mozilla-b2g/gaia/commit/78451cc7cdb2a5fc0be364129d0abb9fd5338b62
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Verified fixed on Unagi build 20130102070202.
Shared a photo in the Gallery via e-mail and the file name appeared in the composition of the e-mail.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.