DeviceManagerSUT.pushFile() has invalid debug statement

RESOLVED FIXED

Status

Testing
Mozbase
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: mcote, Assigned: mihneadb)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
In DeviceManagerSUT.pushFile(), there is this:

if (self.debug >= 3):
    print "push returned: %s" % hash

This results in this output: "push returned: <built-in function hash>"

I believe that 'hash' should be 'remoteHash' here.
(Assignee)

Comment 1

6 years ago
Created attachment 715115 [details] [diff] [review]
fix this

One more giant patch :).
Assignee: nobody → mihneadb
Attachment #715115 - Flags: review?(mcote)
(Reporter)

Comment 2

6 years ago
Comment on attachment 715115 [details] [diff] [review]
fix this

Thanks. :)
Attachment #715115 - Flags: review?(mcote) → review+
(Assignee)

Comment 3

6 years ago
Pushed: https://github.com/mozilla/mozbase/commit/f189dcca4c87a10604a18feab588d4752aa3568e
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Blocks: 819664
You need to log in before you can comment on or make changes to this bug.