Closed Bug 805596 Opened 12 years ago Closed 12 years ago

MediaEngineDefault must use reasonable values for fake Audio streams

Categories

(Core :: WebRTC: Networking, defect)

Product:
Core
Component:
WebRTC: Networking
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla19
Tracking Flags:
Tracking Status
firefox18 --- unaffected
firefox19 --- fixed

People

(Reporter: jesup, Assigned: jesup)

References

(
URL
)

Details

(Whiteboard: [getUserMedia], [blocking-gum+] [qa-])

Attachments

(1 file)

Use something reasonable for rates
2.54 KB, patch
anant
: review+
Details | Diff | Splinter Review 
Got this while testing something else.  Note the samplingFreq, which means video (and length of samples).  Unsure if this is repeatable.

#5  0x00007f12007a5f1a in mozilla::WebrtcAudioConduit::SendAudioFrame (this=0x7f11df2d6fd0, 
    audio_data=0x7f11ddcc2710, lengthSamples=1, samplingFreqHz=1000000, capture_delay=0)
    at ../../../../../media/webrtc/signaling/src/media-conduit/AudioConduit.cpp:373
#6  0x00007f12007f0aac in mozilla::MediaPipelineTransmit::ProcessAudioChunk (this=0x7f11e389a4a0, 
    conduit=0x7f11df2d6fd0, rate=1000000, chunk=...)
    at ../../../../../media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp:589
#7  0x00007f12007f0566 in mozilla::MediaPipelineTransmit::PipelineListener::NotifyQueuedTrackChanges (this=0x7f11e44afaa0, graph=0x7f11df0e3f00, tid=2, rate=1000000, offset=9, events=0, queued_media=
    ...) at ../../../../../media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp:522
#8  0x00007f11ff193505 in mozilla::MediaStreamGraphImpl::ExtractPendingInput (this=0x7f11df0e3f00, 
    aStream=0x7f11df4f0e50, aDesiredUpToTime=534734, aEnsureNextIteration=0x7f11dc9fbb9f)
    at ../../../content/media/MediaStreamGraph.cpp:612
#9  0x00007f11ff1962c7 in mozilla::MediaStreamGraphImpl::RunThread (this=0x7f11df0e3f00)
    at ../../../content/media/MediaStreamGraph.cpp:1392
#10 0x00007f11ff196a69 in mozilla::(anonymous namespace)::MediaStreamGraphThreadRunnable::Run (
    this=0x7f11e43f9480) at ../../../content/media/MediaStreamGraph.cpp:1524
MediaEngineDefault.cpp was using 1MHz for audio sampling rate, and was inserting 1 sample (1 microsecond) of Null data to start.  Not sure why MediaPipeline didn't start kicking out until now, but it is now.
Assignee: nobody → rjesup
Summary: MediaPipeline somehow got a video MediaStream feeding an audio pipeline/conduit → MediaEngineDefault must use reasonable values for fake Audio streams
Whiteboard: [getUserMedia], [blocking-gum+]
Severity: major → blocker
Attachment #675305 - Flags: review?(anant) → review+
https://hg.mozilla.org/mozilla-central/rev/b36eeabe85b5
Status: NEW → RESOLVED
Closed: 12 years ago
status-firefox18: --- → unaffected
status-firefox19: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Whiteboard: [getUserMedia], [blocking-gum+] → [getUserMedia], [blocking-gum+] [qa-]
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: