805646 - Allow access fields in manifest files.

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gregor Wagner [:gwagner]]

We need this to allow readonly access to the settings api for example.

Comment 1

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 2

[Gregor Wagner [:gwagner]]

Attachment: patch

now without debug output

Comment 3

[Gregor Wagner [:gwagner]]

Attachment: Gaia patch

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 675344 [details] [diff] [review]
Gaia patch

Review of attachment 675344 [details] [diff] [review]:
-----------------------------------------------------------------

::: apps/camera/manifest.webapp
@@ +10,5 @@
>      "url": "https://github.com/mozilla-b2g/gaia"
>    },
>    "permissions": {
> +    "device-storage:pictures":{ "access": "readcreate" },
> +    "device-storage:videos":{ "access": "readcreate" },

I think these can be "createonly", but I'm not sure.

::: apps/communications/manifest.webapp
@@ +28,4 @@
>    "permissions": {
>      "telephony":{},
>      "voicemail":{},
> +    "contacts":{ "access": "readcreate" },

This should be "readwrite"

::: apps/gallery/manifest.webapp
@@ +8,4 @@
>      "url": "https://github.com/mozilla-b2g/gaia"
>    },
>    "permissions": {
> +    "device-storage:pictures":{ "access": "readonly" },

This needs "readwrite" in order to delete pictures.

::: apps/homescreen/manifest.webapp
@@ +9,5 @@
>    "permissions": {
>      "webapps-manage":{},
>      "systemXHR":{},
> +    "settings":{ "access": "readonly" },
> +    "device-storage:pictures":{ "access": "readcreate" }

Shouldn't "readonly" be enough here?

::: apps/music/manifest.webapp
@@ +8,4 @@
>      "url": "https://github.com/mozilla-b2g/gaia"
>    },
>    "permissions": {
> +    "device-storage:music":{ "access": "readcreate" },

probably needs "readwrite" in order to delete songs.

::: apps/system/manifest.webapp
@@ +18,3 @@
>      "telephony":{},
>      "voicemail":{},
>      "device-storage:pictures":{},

Probably needs "readcreate" here to save screenshots

::: apps/video/manifest.webapp
@@ +8,4 @@
>      "url": "https://github.com/mozilla-b2g/gaia"
>    },
>    "permissions": {
> +    "device-storage:videos":{ "access": "readonly" },

This probably needs "readwrite" in order to delete videos

::: test_apps/image-uploader/manifest.webapp
@@ +7,4 @@
>    },
>    "permissions": {
>      "systemXHR":{},
> +    "device-storage:pictures":{ "access": "readcreate" }

I suspect "readonly" is enough here.

::: test_apps/uitest/manifest.webapp
@@ +11,4 @@
>    "permissions": {
>      "backgroundservice":{},
>      "attention":{},
> +    "contacts":{ "access": "readcreate" },

readwrite maybe?

Comment 5

[David Dahl :ddahl]

Comment on attachment 675335 [details] [diff] [review]
patch

Looks Good

Comment 6

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/55e06361e08e

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/55e06361e08e

Comment 8

[Jason Smith [:jsmith]]

Umm...where's the reference to the Gaia portion of the patch?

Comment 9

[Gregor Wagner [:gwagner]]

(In reply to Jason Smith [:jsmith] from comment #8)
> Umm...where's the reference to the Gaia portion of the patch?

Hasn't landed yet because we have distribute the gecko part on all trees first.
Otherwise we would break nightly again.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4aa98258250b

Comment 11

[Gregor Wagner [:gwagner]]

Gaia part:
https://github.com/mozilla-b2g/gaia/pull/6063