Closed Bug 805646 Opened 8 years ago Closed 8 years ago

Allow access fields in manifest files.

Categories

(Core :: DOM: Device Interfaces, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla19
blocking-basecamp +
Tracking Status
firefox18 --- fixed
firefox19 --- fixed

People

(Reporter: gwagner, Assigned: gwagner)

References

Details

(Whiteboard: [qa-])

Attachments

(2 files, 1 obsolete file)

We need this to allow readonly access to the settings api for example.
blocking-basecamp: --- → ?
Blocks: 776668
Attached patch patch (obsolete) — Splinter Review
Attached patch patchSplinter Review
now without debug output
Attachment #675334 - Attachment is obsolete: true
Attached patch Gaia patchSplinter Review
Attachment #675344 - Flags: review?(jonas)
Attachment #675335 - Flags: review?(ddahl)
Comment on attachment 675344 [details] [diff] [review]
Gaia patch

Review of attachment 675344 [details] [diff] [review]:
-----------------------------------------------------------------

::: apps/camera/manifest.webapp
@@ +10,5 @@
>      "url": "https://github.com/mozilla-b2g/gaia"
>    },
>    "permissions": {
> +    "device-storage:pictures":{ "access": "readcreate" },
> +    "device-storage:videos":{ "access": "readcreate" },

I think these can be "createonly", but I'm not sure.

::: apps/communications/manifest.webapp
@@ +28,4 @@
>    "permissions": {
>      "telephony":{},
>      "voicemail":{},
> +    "contacts":{ "access": "readcreate" },

This should be "readwrite"

::: apps/gallery/manifest.webapp
@@ +8,4 @@
>      "url": "https://github.com/mozilla-b2g/gaia"
>    },
>    "permissions": {
> +    "device-storage:pictures":{ "access": "readonly" },

This needs "readwrite" in order to delete pictures.

::: apps/homescreen/manifest.webapp
@@ +9,5 @@
>    "permissions": {
>      "webapps-manage":{},
>      "systemXHR":{},
> +    "settings":{ "access": "readonly" },
> +    "device-storage:pictures":{ "access": "readcreate" }

Shouldn't "readonly" be enough here?

::: apps/music/manifest.webapp
@@ +8,4 @@
>      "url": "https://github.com/mozilla-b2g/gaia"
>    },
>    "permissions": {
> +    "device-storage:music":{ "access": "readcreate" },

probably needs "readwrite" in order to delete songs.

::: apps/system/manifest.webapp
@@ +18,3 @@
>      "telephony":{},
>      "voicemail":{},
>      "device-storage:pictures":{},

Probably needs "readcreate" here to save screenshots

::: apps/video/manifest.webapp
@@ +8,4 @@
>      "url": "https://github.com/mozilla-b2g/gaia"
>    },
>    "permissions": {
> +    "device-storage:videos":{ "access": "readonly" },

This probably needs "readwrite" in order to delete videos

::: test_apps/image-uploader/manifest.webapp
@@ +7,4 @@
>    },
>    "permissions": {
>      "systemXHR":{},
> +    "device-storage:pictures":{ "access": "readcreate" }

I suspect "readonly" is enough here.

::: test_apps/uitest/manifest.webapp
@@ +11,4 @@
>    "permissions": {
>      "backgroundservice":{},
>      "attention":{},
> +    "contacts":{ "access": "readcreate" },

readwrite maybe?
Attachment #675344 - Flags: review?(jonas) → review+
Comment on attachment 675335 [details] [diff] [review]
patch

Looks Good
Attachment #675335 - Flags: review?(ddahl) → review+
blocking-basecamp: ? → +
https://hg.mozilla.org/mozilla-central/rev/55e06361e08e
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Umm...where's the reference to the Gaia portion of the patch?
Keywords: verifyme
QA Contact: jsmith
(In reply to Jason Smith [:jsmith] from comment #8)
> Umm...where's the reference to the Gaia portion of the patch?

Hasn't landed yet because we have distribute the gecko part on all trees first.
Otherwise we would break nightly again.
Keywords: verifyme
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.