Allow access fields in manifest files.

RESOLVED FIXED in Firefox 18

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: gwagner, Assigned: gwagner)

Tracking

unspecified
mozilla19
x86
macOS
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(blocking-basecamp:+, firefox18 fixed, firefox19 fixed)

Details

(Whiteboard: [qa-])

Attachments

(2 attachments, 1 obsolete attachment)

Assignee

Description

7 years ago
We need this to allow readonly access to the settings api for example.
Assignee

Updated

7 years ago
blocking-basecamp: --- → ?
Assignee

Updated

7 years ago
Blocks: 776668
Assignee

Comment 1

7 years ago
Posted patch patch (obsolete) — Splinter Review
Assignee

Comment 2

7 years ago
Posted patch patchSplinter Review
now without debug output
Attachment #675334 - Attachment is obsolete: true
Assignee

Comment 3

7 years ago
Posted patch Gaia patchSplinter Review
Assignee

Updated

7 years ago
Attachment #675344 - Flags: review?(jonas)
Assignee

Updated

7 years ago
Attachment #675335 - Flags: review?(ddahl)
Comment on attachment 675344 [details] [diff] [review]
Gaia patch

Review of attachment 675344 [details] [diff] [review]:
-----------------------------------------------------------------

::: apps/camera/manifest.webapp
@@ +10,5 @@
>      "url": "https://github.com/mozilla-b2g/gaia"
>    },
>    "permissions": {
> +    "device-storage:pictures":{ "access": "readcreate" },
> +    "device-storage:videos":{ "access": "readcreate" },

I think these can be "createonly", but I'm not sure.

::: apps/communications/manifest.webapp
@@ +28,4 @@
>    "permissions": {
>      "telephony":{},
>      "voicemail":{},
> +    "contacts":{ "access": "readcreate" },

This should be "readwrite"

::: apps/gallery/manifest.webapp
@@ +8,4 @@
>      "url": "https://github.com/mozilla-b2g/gaia"
>    },
>    "permissions": {
> +    "device-storage:pictures":{ "access": "readonly" },

This needs "readwrite" in order to delete pictures.

::: apps/homescreen/manifest.webapp
@@ +9,5 @@
>    "permissions": {
>      "webapps-manage":{},
>      "systemXHR":{},
> +    "settings":{ "access": "readonly" },
> +    "device-storage:pictures":{ "access": "readcreate" }

Shouldn't "readonly" be enough here?

::: apps/music/manifest.webapp
@@ +8,4 @@
>      "url": "https://github.com/mozilla-b2g/gaia"
>    },
>    "permissions": {
> +    "device-storage:music":{ "access": "readcreate" },

probably needs "readwrite" in order to delete songs.

::: apps/system/manifest.webapp
@@ +18,3 @@
>      "telephony":{},
>      "voicemail":{},
>      "device-storage:pictures":{},

Probably needs "readcreate" here to save screenshots

::: apps/video/manifest.webapp
@@ +8,4 @@
>      "url": "https://github.com/mozilla-b2g/gaia"
>    },
>    "permissions": {
> +    "device-storage:videos":{ "access": "readonly" },

This probably needs "readwrite" in order to delete videos

::: test_apps/image-uploader/manifest.webapp
@@ +7,4 @@
>    },
>    "permissions": {
>      "systemXHR":{},
> +    "device-storage:pictures":{ "access": "readcreate" }

I suspect "readonly" is enough here.

::: test_apps/uitest/manifest.webapp
@@ +11,4 @@
>    "permissions": {
>      "backgroundservice":{},
>      "attention":{},
> +    "contacts":{ "access": "readcreate" },

readwrite maybe?
Attachment #675344 - Flags: review?(jonas) → review+

Comment 5

7 years ago
Comment on attachment 675335 [details] [diff] [review]
patch

Looks Good
Attachment #675335 - Flags: review?(ddahl) → review+
blocking-basecamp: ? → +
https://hg.mozilla.org/mozilla-central/rev/55e06361e08e
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Umm...where's the reference to the Gaia portion of the patch?
Keywords: verifyme
QA Contact: jsmith
Assignee

Comment 9

7 years ago
(In reply to Jason Smith [:jsmith] from comment #8)
> Umm...where's the reference to the Gaia portion of the patch?

Hasn't landed yet because we have distribute the gecko part on all trees first.
Otherwise we would break nightly again.
Keywords: verifyme
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.