805648 - onlogout / onlogin not called from watch() in trusty UI

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Kumar McMillan [:kumar]]

Attachment: b2g log

I ran into an issue when integrating id.watch() on b2g for nav.mozPay() (bug 804848).

It seems that onlogout should be called but it's not. From the logs, doReady is called but not doLogout.

This is using the dev version of identity: https://gist.github.com/3778932

First, the marketplace app calls id.watch() and that works. Next it loads webpay in the trusty UI using nav.mozPay(). That calls id.watch() again and that's where I'm stuck. It never calls any callbacks. A log is attached.

Comment 1

[Jason Smith [:jsmith]]

Are there any workarounds?

Comment 2

[Jason Smith [:jsmith]]

Noming anyways just in case.

Comment 3

[Ben Adida [:benadida]]

Jason: this is definitely blocking-basecamp, it's a bug in the integration of payments and identity, without which you can't do in-app payment.

Comment 4

[Jason Smith [:jsmith]]

(In reply to Ben Adida [:benadida] from comment #3)
> Jason: this is definitely blocking-basecamp, it's a bug in the integration
> of payments and identity, without which you can't do in-app payment.

Ah okay, makes sense. Feel free to set the flag then to +.

Comment 5

[Kumar McMillan [:kumar]]

I'm not sure exactly what is triggering this behavior but if you want to try calling navigator.id.watch() from within navigator.mozPay() here's how to set that up:

1) make a web page that calls navigator.mozPay([jwt]) from b2g. It doesn't have to be an app.
2) edit your dom prefs to whitelist a pay server like https://github.com/mozilla/webpay#setting-up-your-b2g-device
3) The pay server can be any web server but make sure it is reachable via https
4) have that pay server try to call navigator.id.watch()

The JWT you pass to the JS call needs to be well formed but it can be an expired JWT too. You could grab the test JWT from this: https://github.com/mozilla-b2g/gaia/blob/master/test_apps/uitest/tests/pay.html

Comment 6

[Kumar McMillan [:kumar]]

Hooray! jed fixed this. I think he still needs an r? on the patch so I'll let him closed. The target moved to bug 807122

Comment 7

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Thanks, Kumar.  Glad this is working.  For those reading along, the relevant patches for this bug are:

Bug 807078
Bug 807122

Once they're landed, I'll go ahead and close this.

Comment 8

[Ben Adida [:benadida]]

Caitlin: this is a bug with the way the trusty UI works, so I don't think the label feature-complete makes sense.

Comment 9

[Andreas Gal :gal]

How are we doing here?

Comment 10

[Ben Adida [:benadida]]

(In reply to Andreas Gal :gal from comment #9)
> How are we doing here?

This work is now happening in bug 807122, as per Kumar's comment. That work is almost done, pending a Gaia PR.

Kumar: can you confirm that bug 807122 will handle what you need?

Comment 11

[Kumar McMillan [:kumar]]

Yep, all good on the marketplace app. I tested using today's nightly B2G desktop and gaia master. With the correct custom settings I could use Persona in the purchase window. bug 807122 is completely fixed for me.

Comment 12

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

(In reply to Kumar McMillan [:kumar] from comment #11)
> Yep, all good on the marketplace app. I tested using today's nightly B2G
> desktop and gaia master. With the correct custom settings I could use
> Persona in the purchase window. bug 807122 is completely fixed for me.

Thanks for the report, Kumar!  I've gone ahead and marked Bug 807122 as resolved, and I will now close this bug as well.