805724 - [b2g-bluetooth] misc BluetoothOppManager cleanup

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Eric Chou [:ericchou] [:echou]]

Once bug 803614 and bug 802080 land, most Object Push functions for v1 are done. However there are still some cleanups and small fixes have to be done.

Comment 1

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v1: made BluetoothOppManager listen again after disconnection

* do stuff similar to 804436

Comment 2

[Andrew Overholt [:overholt]]

These cleanups (closing socket, etc.) seem important enough that we don't want them to regress so let's block on it.

Comment 3

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 2: v1: cleanup (naming, check text width, decrease build warnings)

Comment 4

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 3: v1: let user be able to terminate receiving process by calling StopSendingFile()

Comment 5

[Eric Chou [:ericchou] [:echou]]

(In reply to Eric Chou [:ericchou] [:echou] from comment #4)
> Created attachment 676979 [details] [diff] [review]
> patch 3: v1: let user be able to terminate receiving process by calling
> StopSendingFile()

Forgot to say, I removed the mBlob checking block from StopSendingFile() because mBlob will only be created when we send file.

Comment 6

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 4: v1: fire dom request events after calling OPP related functions

* Fired onsuccess and onerror events of DOM requests which are generated from calling BluetoothOppManager.StopReceivingFile() / SendFile() / ConfirmReceivingFile()

Comment 7

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 5: v1: sent correct file name to Gaia and removed received incomplete file

* After using CreateUnique() to create a file, originally assigned file name may be changed if a file with the same name already exists to guarantee uniqueness. 
Therefore we have to get file name again.
* Removed incomplete received file after user terminated the file transferring process.

Comment 8

[Eric Chou [:ericchou] [:echou]]

try:

https://tbpl.mozilla.org/?tree=Try&rev=2946f2137533
https://tbpl.mozilla.org/?tree=Try&rev=16dc8e5054d7

Comment 9

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d5a243157a1
https://hg.mozilla.org/integration/mozilla-inbound/rev/4dee151d9691
https://hg.mozilla.org/integration/mozilla-inbound/rev/35e8f03df16f
https://hg.mozilla.org/integration/mozilla-inbound/rev/25bdd962839f
https://hg.mozilla.org/integration/mozilla-inbound/rev/12e3879d1fb3

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9d5a243157a1
https://hg.mozilla.org/mozilla-central/rev/4dee151d9691
https://hg.mozilla.org/mozilla-central/rev/35e8f03df16f
https://hg.mozilla.org/mozilla-central/rev/25bdd962839f
https://hg.mozilla.org/mozilla-central/rev/12e3879d1fb3

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5723c03e806e
https://hg.mozilla.org/releases/mozilla-aurora/rev/471d6d92eceb
https://hg.mozilla.org/releases/mozilla-aurora/rev/3c39eafb24a1
https://hg.mozilla.org/releases/mozilla-aurora/rev/acda15a7388b
https://hg.mozilla.org/releases/mozilla-aurora/rev/852c98a08997

Note that the second hunk of patch 2 couldn't be applied to BluetoothOppManager.cpp because the code in question wasn't present.