Closed
Bug 805773
Opened 7 years ago
Closed 7 years ago
TestSHA1.exe fails to link on mingw
Categories
(Core :: MFBT, defect)
Not set
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: jacek, Assigned: jacek)
Details
Attachments
(1 file)
|
717 bytes,
patch
|
espindola
:
review+
|
Details | Diff | Splinter Review |
On mingw, functions declared as dllimport use symbols that are defined when import library is created. Since we link tests directly to object files, the import library is never created. The attached patch solves the problem by always using exactly the same declarations in tests as in implementation.
Attachment #675515 -
Flags: review?(respindola)
|
Assignee | |
Comment 1•7 years ago
|
||
Try commit: https://tbpl.mozilla.org/?tree=Try&rev=8a6756e11161
Attachment #675515 -
Flags: review?(respindola) → review+
|
|
Assignee | |
Comment 2•7 years ago
|
||
Thanks for review. https://hg.mozilla.org/integration/mozilla-inbound/rev/93bfd0a08a35
|
||
Comment 3•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/93bfd0a08a35
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in
before you can comment on or make changes to this bug.
Description
•