805787 - build failure (link errors for nsIMutationObserver methods) with apple clang on OS X since bug 805527 landed

Status: RESOLVED FIXED

(Core :: XBL, defect)

Description

[Jonathan Kew [:jfkthame]]

Using the current Apple xcode tools on OS X 10.7:

Undefined symbols for architecture x86_64:
  "nsIMutationObserver::ContentRemoved(nsIDocument*, nsIContent*, nsIContent*, int, nsIContent*)", referenced from:
      nsNodeUtils::ContentRemoved(nsINode*, nsIContent*, int, nsIContent*) in nsNodeUtils.o
  "nsIMutationObserver::ContentAppended(nsIDocument*, nsIContent*, nsIContent*, int)", referenced from:
      nsNodeUtils::ContentAppended(nsIContent*, nsIContent*, int) in nsNodeUtils.o
  "nsIMutationObserver::ContentInserted(nsIDocument*, nsIContent*, nsIContent*, int)", referenced from:
      nsNodeUtils::ContentInserted(nsINode*, nsIContent*, int) in nsNodeUtils.o
  "nsIMutationObserver::AttributeChanged(nsIDocument*, mozilla::dom::Element*, int, nsIAtom*, int)", referenced from:
      nsNodeUtils::AttributeChanged(mozilla::dom::Element*, int, nsIAtom*, int) in nsNodeUtils.o
  "nsIMutationObserver::AttributeWillChange(nsIDocument*, mozilla::dom::Element*, int, nsIAtom*, int)", referenced from:
      nsNodeUtils::AttributeWillChange(mozilla::dom::Element*, int, nsIAtom*, int) in nsNodeUtils.o
  "nsIMutationObserver::CharacterDataChanged(nsIDocument*, nsIContent*, CharacterDataChangeInfo*)", referenced from:
      nsNodeUtils::CharacterDataChanged(nsIContent*, CharacterDataChangeInfo*) in nsNodeUtils.o
  "nsIMutationObserver::CharacterDataWillChange(nsIDocument*, nsIContent*, CharacterDataChangeInfo*)", referenced from:
      nsNodeUtils::CharacterDataWillChange(nsIContent*, CharacterDataChangeInfo*) in nsNodeUtils.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

(Note also bug 805527 comment 5.)

Thanks to dbaron for pinpointing the problematic line and how to resolve it.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: fix for build failure in nsNodeUtils.cpp with Apple clang 4.0 or other not-up-to-date versions

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 675525 [details] [diff] [review]
fix for build failure in nsNodeUtils.cpp with Apple clang 4.0 or other not-up-to-date versions

r=dbaron

Comment 4

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/mozilla-central/rev/80e4065a329e

Comment 5

[(no longer active)]

Can someone please look at the generated code and make sure that this generates the correct code with the xcode clang?