Closed Bug 805805 Opened 7 years ago Closed 7 years ago

Package Dom Permission Settings from Bug 770731 (Expose JS API for modifying app permissions)

Categories

(SeaMonkey :: Installer, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.16

People

(Reporter: philip.chee, Assigned: philip.chee)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Core Bug 770731 - Expose JS API for modifying app permissions.
Changeset: https://hg.mozilla.org/mozilla-central/rev/aa121eb77862
Target Milestone: Mozilla18
Blocks: 803168
Callek seems to be very busy these days so setting r? flag to mcsmurf.


To test set dom.mozPermissionSettings.enabled true, Restart SeaMonkey.
Then inspect navigator.mozPermissionSettings

Properties for object:
[xpconnect wrapped nsIDOMPermissionSettings]
QueryInterface: function QueryInterface() {
    [native code]
}
get: function get() {
    [native code]
}
set: function set() {
    [native code]
}
Assignee: installer → philip.chee
Status: NEW → ASSIGNED
Attachment #676193 - Flags: review?(bugzilla)
Comment on attachment 676193 [details] [diff] [review]
Patch v1.0 Package it.

Why the +  components/PermissionSettings.js change to removed-files.in? This file should be added, not removed...?
It's added in package-manifest and removed in removed-files ;)
As to why, you'll have to ask Serge or Callek. I'm just following previous patches I did which were reviewed by Serge.
Comment on attachment 676193 [details] [diff] [review]
Patch v1.0 Package it.

r+, but only with the removed-files.in change removed. The removed-files.in change would have been needed if this file was ever included in an official build which does not use omnijar. Our official builds always use omnijar (see http://mxr.mozilla.org/comm-central/source/suite/confvars.sh#13). Including those files in removed-files.in just slows down the installer.
Attachment #676193 - Flags: review?(bugzilla) → review+
> r+, but only with the removed-files.in change removed
Fixed. And Pushed:

http://hg.mozilla.org/comm-central/rev/d7f2c49df063
Attachment #678016 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.16
You need to log in before you can comment on or make changes to this bug.