805805 - Package Dom Permission Settings from Bug 770731 (Expose JS API for modifying app permissions)

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Philip Chee]

Core Bug 770731 - Expose JS API for modifying app permissions.
Changeset: https://hg.mozilla.org/mozilla-central/rev/aa121eb77862
Target Milestone: Mozilla18

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Package it.

Callek seems to be very busy these days so setting r? flag to mcsmurf.


To test set dom.mozPermissionSettings.enabled true, Restart SeaMonkey.
Then inspect navigator.mozPermissionSettings

Properties for object:
[xpconnect wrapped nsIDOMPermissionSettings]
QueryInterface: function QueryInterface() {
    [native code]
}
get: function get() {
    [native code]
}
set: function set() {
    [native code]
}

Comment 2

[Frank Wein [:mcsmurf]]

Comment on attachment 676193 [details] [diff] [review]
Patch v1.0 Package it.

Why the +  components/PermissionSettings.js change to removed-files.in? This file should be added, not removed...?

Comment 3

[Philip Chee]

It's added in package-manifest and removed in removed-files ;)
As to why, you'll have to ask Serge or Callek. I'm just following previous patches I did which were reviewed by Serge.

Comment 4

[Frank Wein [:mcsmurf]]

Comment on attachment 676193 [details] [diff] [review]
Patch v1.0 Package it.

r+, but only with the removed-files.in change removed. The removed-files.in change would have been needed if this file was ever included in an official build which does not use omnijar. Our official builds always use omnijar (see http://mxr.mozilla.org/comm-central/source/suite/confvars.sh#13). Including those files in removed-files.in just slows down the installer.

Comment 5

[Philip Chee]

Attachment: Patch v1.1 without removed-files.in as pushed r=mcsmurf. [check-in comment 5]

> r+, but only with the removed-files.in change removed
Fixed. And Pushed:

http://hg.mozilla.org/comm-central/rev/d7f2c49df063