Closed
Bug 805829
Opened 12 years ago
Closed 12 years ago
Add test-container app to gaia/test_apps for loading mochitests (and other frameworks) oop
Categories
(Firefox OS Graveyard :: Gaia, defect)
Firefox OS Graveyard
Gaia
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: ahal, Assigned: ahal)
References
Details
Attachments
(1 file, 1 obsolete file)
2.15 KB,
patch
|
fabrice
:
review+
cjones
:
approval-gaia-v1+
|
Details | Diff | Splinter Review |
We need to replace the system app with a test shim app that runs in process but exposes an oop <iframe mozbrowser> which can be used to load our various test frameworks (in particular mochitest).
See https://bugzilla.mozilla.org/show_bug.cgi?id=798580#c32
Assignee | ||
Comment 1•12 years ago
|
||
I'm not familiar with the gaia workflow. Feel free to re-assign review, or let me know if I should make a pull request.
Attachment #675688 -
Flags: review?(fabrice)
Assignee | ||
Comment 2•12 years ago
|
||
Comment on attachment 675688 [details] [diff] [review]
Patch 1.0 - Add shim app
I realized if this is going to be used by other harnesses in the future then the iframe will need to take up the full screen (e.g reftests require a very specific resolution).
New patch coming soon.
Attachment #675688 -
Flags: review?(fabrice)
Assignee | ||
Comment 3•12 years ago
|
||
Set size 100% and remove borders
Attachment #675688 -
Attachment is obsolete: true
Attachment #677009 -
Flags: review?(fabrice)
Comment 4•12 years ago
|
||
Comment on attachment 677009 [details] [diff] [review]
Patch 2.0 - Add shim with fullscreen iframe
Review of attachment 677009 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good!
Attachment #677009 -
Flags: review?(fabrice) → review+
Assignee | ||
Comment 5•12 years ago
|
||
Sent pull request: https://github.com/mozilla-b2g/gaia/pull/6122
a=me, test only and needed for mochitests.
Updated•12 years ago
|
Attachment #677009 -
Flags: approval-gaia-master+
Assignee | ||
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Device: Unagi
Build: 20130112070202
Does not reproduce at this time.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•