805871 - Peer Connection cannot be established

Status: VERIFIED FIXED

(Core :: WebRTC, defect)

Description

[Nagarjuna Varma [:Infinity]]

The peer connection test provided at https://people.mozilla.com/~anarayanan/webrtc/pc_test.html does not work due to the following error even though all the right prefs are set:
[23:28:05.976] NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [IPeerConnection.initialize] @ resource://gre/components/PeerConnection.js:211

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Note: when I try modifying the page, I find the error occurs when I call createOffer().

I see this:
 JavaScript error: , line 0: Permission denied to access object
With a local build on Linux.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I wonder which patch caused this regression. Nagarjuna, would you mind to test the latest tinderbox builds which are getting created for each commit? You can find them here:

http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/

Comment 3

[Anant Narayanan [:anant]]

It might be the constraints fix, but I'm not sure.

I can reproduce, investigating further.

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Add {} as the last parameter to createOffer() and createAnswer() and the demo page works.

For some reason the constraints are mandatory to supply (xpconnect/idl definition issue likely)

Comment 5

[Anant Narayanan [:anant]]

Attachment: Tentative fix

Tentative fix, currently building to verify.

Comment 6

[Anant Narayanan [:anant]]

Attachment: Tentative fix - v2

Slightly cleaner version.

Comment 7

[Anant Narayanan [:anant]]

Attachment: Make constraints really optional

Missed createAnswer in the earlier patch.

Comment 8

[Anant Narayanan [:anant]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a94c45bf8d24

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a94c45bf8d24

Comment 10

[Jason Smith [:jsmith]]

Hmm...I tried Anant's test case on the nightly 10/28 build here - https://people.mozilla.com/~anarayanan/webrtc/pc_test.html. I called start, allowed access to my camera, but only the video at the bottom (not attached to any peer connection) appeared. I didn't see the HTML dump indicating the pcs were successful, and those pc videos aren't playing either.

OS: Windows 7 64-bit
Error Console Info: None

Any ideas?

Comment 11

[Nagarjuna Varma [:Infinity]]

That's really strange. I just tried it out in the evening on Sunday (Indian time) and it worked and now it doesn't for me too. I am getting the same error as :jsmith which shows me the same log as in the description of this bug.

Comment 12

[Jason Smith [:jsmith]]

(In reply to Nagarjuna Varma [:Infinity] from comment #11)
> That's really strange. I just tried it out in the evening on Sunday (Indian
> time) and it worked and now it doesn't for me too. I am getting the same
> error as :jsmith which shows me the same log as in the description of this
> bug.

Are you using the latest nightly build with this bug fix in?

Comment 13

[Anant Narayanan [:anant]]

I tried with both the 28th and 29th build and it worked fine. Check prefs?

Comment 14

[Nagarjuna Varma [:Infinity]]

Yeah. I have Nightly up to date and I have prefs enabled. It worked yesterday. Doesn't work today.
OS: Windows7
    64 bit

Comment 15

[Jason Smith [:jsmith]]

(In reply to Anant Narayanan [:anant] from comment #13)
> I tried with both the 28th and 29th build and it worked fine. Check prefs?

prefs look fine. Sounds like I may be hitting what Ted hit in bug 806407.

Comment 16

[Jason Smith [:jsmith]]

(In reply to Anant Narayanan [:anant] from comment #13)
> I tried with both the 28th and 29th build and it worked fine. Check prefs?

Hmm...and now it works. Something weird is going on here....

Comment 17

[Jason Smith [:jsmith]]

Verified on 10/29 nightly build.