Closed Bug 805871 Opened 7 years ago Closed 7 years ago

Peer Connection cannot be established

Categories

(Core :: WebRTC, defect, critical)

19 Branch
defect
Not set
critical

Tracking

()

VERIFIED FIXED
mozilla19

People

(Reporter: Infinity, Assigned: anant)

Details

(Keywords: regression, Whiteboard: [WebRTC])

Attachments

(1 file, 2 obsolete files)

The peer connection test provided at https://people.mozilla.com/~anarayanan/webrtc/pc_test.html does not work due to the following error even though all the right prefs are set:
[23:28:05.976] NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [IPeerConnection.initialize] @ resource://gre/components/PeerConnection.js:211
Whiteboard: [WebRTC]
Note: when I try modifying the page, I find the error occurs when I call createOffer().

I see this:
 JavaScript error: , line 0: Permission denied to access object
With a local build on Linux.
OS: Windows 7 → All
Hardware: x86_64 → All
I wonder which patch caused this regression. Nagarjuna, would you mind to test the latest tinderbox builds which are getting created for each commit? You can find them here:

http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/
Severity: normal → critical
It might be the constraints fix, but I'm not sure.

I can reproduce, investigating further.
Add {} as the last parameter to createOffer() and createAnswer() and the demo page works.

For some reason the constraints are mandatory to supply (xpconnect/idl definition issue likely)
Attached patch Tentative fix (obsolete) — Splinter Review
Tentative fix, currently building to verify.
Assignee: nobody → anant
Status: NEW → ASSIGNED
Attachment #675643 - Flags: review?(rjesup)
Attached patch Tentative fix - v2 (obsolete) — Splinter Review
Slightly cleaner version.
Attachment #675643 - Attachment is obsolete: true
Attachment #675643 - Flags: review?(rjesup)
Attachment #675647 - Flags: review?(rjesup)
Attachment #675647 - Flags: review?(rjesup) → review+
Missed createAnswer in the earlier patch.
Attachment #675647 - Attachment is obsolete: true
Attachment #675704 - Flags: review?(rjesup)
Attachment #675704 - Flags: review?(rjesup) → review+
https://hg.mozilla.org/mozilla-central/rev/a94c45bf8d24
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Hmm...I tried Anant's test case on the nightly 10/28 build here - https://people.mozilla.com/~anarayanan/webrtc/pc_test.html. I called start, allowed access to my camera, but only the video at the bottom (not attached to any peer connection) appeared. I didn't see the HTML dump indicating the pcs were successful, and those pc videos aren't playing either.

OS: Windows 7 64-bit
Error Console Info: None

Any ideas?
Flags: needinfo?(anant)
Whiteboard: [WebRTC] → [WebRTC], [qa verification blocked]
That's really strange. I just tried it out in the evening on Sunday (Indian time) and it worked and now it doesn't for me too. I am getting the same error as :jsmith which shows me the same log as in the description of this bug.
(In reply to Nagarjuna Varma [:Infinity] from comment #11)
> That's really strange. I just tried it out in the evening on Sunday (Indian
> time) and it worked and now it doesn't for me too. I am getting the same
> error as :jsmith which shows me the same log as in the description of this
> bug.

Are you using the latest nightly build with this bug fix in?
I tried with both the 28th and 29th build and it worked fine. Check prefs?
Flags: needinfo?(anant)
Yeah. I have Nightly up to date and I have prefs enabled. It worked yesterday. Doesn't work today.
OS: Windows7
    64 bit
(In reply to Anant Narayanan [:anant] from comment #13)
> I tried with both the 28th and 29th build and it worked fine. Check prefs?

prefs look fine. Sounds like I may be hitting what Ted hit in bug 806407.
(In reply to Anant Narayanan [:anant] from comment #13)
> I tried with both the 28th and 29th build and it worked fine. Check prefs?

Hmm...and now it works. Something weird is going on here....
Verified on 10/29 nightly build.
Status: RESOLVED → VERIFIED
Whiteboard: [WebRTC], [qa verification blocked] → [WebRTC]
You need to log in before you can comment on or make changes to this bug.