805890 - Needinfo should be possible on closed bugs

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Joe Drew (not getting mail)]

Right now I can't see any way to set needinfo on closed bugs. It should be possible, though!

Comment 1

[:glob ✱]

why would you need to do further work on a closed bug?

Comment 2

[Joe Drew (not getting mail)]

Security bugs need to be backported to other branches.

Comment 3

[David Lawrence [:dkl]]

As it is currently implemented, we do not show the UI under the comment field for setting the needinfo flag if the bug is currently closed. You can, however, set the needinfo flag manually in the flags section of the bug report as we are not filtering there. So you can set the flag there to '?' with or without a requestee.

Now that I think about it, it should have from the beginning automatically cleared the needinfo flag for a closed bug regardless that it is being transitioned from open to closed, but in your case I can hold off on that for the long term.

Now if we want to to actually show the UI under the comment field for closed bugs then we will need to discuss further on how to limit it to certain conditions as I would rather not just do it universally. Possibly only to secure bugs?

dkl

Comment 4

[Joe Drew (not getting mail)]

status-firefoxN:affected would be another reasonable way.

Comment 5

[David Lawrence [:dkl]]

Attachment: Patch to allow needinfo for specific tracking flag (v1)

Comment 6

[:glob ✱]

Comment on attachment 675844 [details] [diff] [review]
Patch to allow needinfo for specific tracking flag (v1)

Review of attachment 675844 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob, with following comments to be addressed on commit

::: extensions/Needinfo/template/en/default/bug/needinfo.html.tmpl
@@ +30,5 @@
>  
> +[% IF user.in_group('canconfirm') && !needinfo_requested %]
> +  [% IF bug.status.is_open %]
> +    [% can_create_needinfo = 1 %]
> +  [% END %]

use ELSE to avoid looping active_fields when a bug is open

@@ +31,5 @@
> +[% IF user.in_group('canconfirm') && !needinfo_requested %]
> +  [% IF bug.status.is_open %]
> +    [% can_create_needinfo = 1 %]
> +  [% END %]
> +  [% FOREACH field = Bugzilla.active_custom_fields(product=>bug.product_obj,component=>bug.component_obj,type=>2) %]

nit: spaces after commas, and around =>

Comment 7

[David Lawrence [:dkl]]

Committing to: bzr+ssh://[e-mail]/bmo/4.0
modified extensions/Needinfo/template/en/default/bug/needinfo.html.tmpl
Committed revision 8368.

Committing to: bzr+ssh://[e-mail]/bmo/4.2
modified extensions/Needinfo/template/en/default/bug/needinfo.html.tmpl
Committed revision 8393.