805952 - Add missing settings to settings.json

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect, P3)

Description

[Gregor Wagner [:gwagner]]

Currently there are not all settings in the SettingsDB.
We need a stable set of settings for the release.

Comment 1

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 2

[Gregor Wagner [:gwagner]]

I need to know what the following settings are for:

+ "operatorvariant.mcc": false,
+ "operatorvariant.mnc": false,

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 675671 [details] [diff] [review]
patch

Review of attachment 675671 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/settings.json
@@ +45,5 @@
>   "lockscreen.enabled": true,
>   "lockscreen.locked": true,
> + "lockscreen.unlock-sound.enabled": false,
> + "operatorvariant.mcc": false,
> + "operatorvariant.mnc": false,

Those are likely integers.

Comment 4

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 5

[[:fabrice] Fabrice Desré]

Comment on attachment 676241 [details] [diff] [review]
patch

Review of attachment 676241 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/settings.json
@@ +19,4 @@
>   "devtools.debugger.log": false,
>   "devtools.debugger.remote-enabled": false,
>   "devtools.debugger.remote-port": 6000,
> + "gaia.system.checkForUpdates":, true,

Nit: there's an extra comma before 'true'

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Why is this minus? this is require to have a list of settings for the release.

Comment 7

[Mike Connor [:mconnor]]

We should have stable settings, blocking+