Closed Bug 805960 Opened 12 years ago Closed 12 years ago

Intermittent toolkit/devtools/webconsole/test/test_file_uri.html | an unexpected uncaught JS exception reported through window.onerror - NS_ERROR_FILE_IS_LOCKED: Component returned failure code: 0x8052000e (NS_ERROR_FILE_IS_LOCKED) [nsILocalFile.remove]

Categories

(DevTools :: Console, defect)

Product:
DevTools
Component:
Console
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g18 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 19
Tracking Flags:
Tracking Status
b2g18 --- fixed

People

(Reporter: msucan, Assigned: msucan)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

updated patch
1.14 KB, patch
Details | Diff | Splinter Review 
First reported by philor in bug 805639 comment 10:

https://tbpl.mozilla.org/php/getParsedLog.php?id=16488980&tree=Firefox

29924 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/devtools/webconsole/test/test_file_uri.html | an unexpected uncaught JS exception reported through window.onerror - NS_ERROR_FILE_IS_LOCKED: Component returned failure code: 0x8052000e (NS_ERROR_FILE_IS_LOCKED) [nsILocalFile.remove] at chrome://mochitests/content/chrome/toolkit/devtools/webconsole/test/test_file_uri.html:82 



Then by RyanVM in bug 805639 comment 14:

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=16499307&tree=Firefox
Rev3 WINNT 5.1 mozilla-central opt test mochitest-other on 2012-10-26 12:53:34
slave: talos-r3-xp-079

29806 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/devtools/webconsole/test/test_file_uri.html | an unexpected uncaught JS exception reported through window.onerror - NS_ERROR_FILE_IS_LOCKED: Component returned failure code: 0x8052000e (NS_ERROR_FILE_IS_LOCKED) [nsILocalFile.remove] at chrome://mochitests/content/chrome/toolkit/devtools/webconsole/test/test_file_uri.html:82
29807 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/devtools/webconsole/test/test_file_uri.html | [SimpleTest.finish()] this test already called finish!
29810 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/devtools/webconsole/test/test_jsterm.html | chrome://mochitests/content/chrome/toolkit/devtools/webconsole/test/test_file_uri.html finished in a non-clean fashion, probably because it didn't call SimpleTest.finish()


This looks to me like a different issue than bug 805639. Thanks!
Attached patch proposed fix (obsolete) — — Splinter Review 
Changed the test_file_uri.html test such that gTmpFile.remove() is now wrapped in a try-catch. The file lock is kept longer than expected and temp file removal fails.

I also touched the test of bug 800231: mainly added a call to editor.focus() - a very small chance that might work.

Thanks!
Assignee: nobody → mihai.sucan
Status: NEW → ASSIGNED
Attachment #676624 - Flags: review?(past)
Attachment #676624 - Flags: review?(past) → review+
Backed out on suspicion of mochitest-1 and 3 permaorange:
https://hg.mozilla.org/integration/fx-team/rev/42b95ac55062
Whiteboard: [orange][fixed-in-fx-team] → [orange]
Also, the part that attempted to fix bug 800231 had an orange in that same push.
Attached patch updated patch — — Splinter Review 
Removed the style editor test changes.

Landed in inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eff984f6154c

Thanks Panos!
Attachment #676624 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/eff984f6154c
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
Whiteboard: [orange]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: