Last Comment Bug 806081 - Remove references from mozilla.com in our mozmill tests
: Remove references from mozilla.com in our mozmill tests
Status: RESOLVED FIXED
:
Product: Mozilla QA
Classification: Other
Component: Mozmill Tests (show other bugs)
: unspecified
: All All
-- normal (vote)
: ---
Assigned To: Henrik Skupin (:whimboo) [away 02/18 - 02/27]
:
:
Mentors:
Depends on:
Blocks: 805705
  Show dependency treegraph
 
Reported: 2012-10-27 06:24 PDT by Henrik Skupin (:whimboo) [away 02/18 - 02/27]
Modified: 2012-10-27 20:29 PDT (History)
2 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---
fixed
fixed
fixed
fixed
fixed


Attachments
Patch v1 (2.26 KB, patch)
2012-10-27 06:25 PDT, Henrik Skupin (:whimboo) [away 02/18 - 02/27]
dave.hunt: review-
Details | Diff | Splinter Review

Description User image Henrik Skupin (:whimboo) [away 02/18 - 02/27] 2012-10-27 06:24:22 PDT
To lower the amount of hosts we connect to for our mozmill tests we should get rid of mozilla.com. Right now only the testStopReloadButtons.js test makes use of it. We can easily port this to mozilla.org until we have a working testcase which works locally.
Comment 1 User image Henrik Skupin (:whimboo) [away 02/18 - 02/27] 2012-10-27 06:25:37 PDT
Created attachment 675832 [details] [diff] [review]
Patch v1
Comment 2 User image Dave Hunt (:davehunt) 2012-10-27 10:21:14 PDT
Comment on attachment 675832 [details] [diff] [review]
Patch v1

Review of attachment 675832 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the whitespace nit addressed.

::: tests/functional/testToolbar/testStopReloadButtons.js
@@ +9,4 @@
>  
>  var setupModule = function(module) {
>    module.controller = mozmill.getBrowserController();
> +  locationBar =  new toolbars.locationBar(controller);

nit: Extra whitespace.
Comment 3 User image Henrik Skupin (:whimboo) [away 02/18 - 02/27] 2012-10-27 11:16:24 PDT
http://hg.mozilla.org/qa/mozmill-tests/rev/8ae83bc17b52 (default)
Comment 4 User image Henrik Skupin (:whimboo) [away 02/18 - 02/27] 2012-10-27 20:29:58 PDT
No test failures so lets get this patch backported:

http://hg.mozilla.org/qa/mozmill-tests/rev/e9bea4e2f8ee (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/0a14d82c63d3 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/16f4876f7d86 (release)
http://hg.mozilla.org/qa/mozmill-tests/rev/4e732c0cff4e (esr10)

Note You need to log in before you can comment on or make changes to this bug.