806116 - touchpad TAP only triggers ":active" with double-tap on element with tabindex

Status: NEW

(Firefox :: General, defect)

Description

[Florian Bender]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/17.0 Firefox/17.0
Build ID: 20121023124120

Steps to reproduce:

This issue is probably Mac-only (internal-touchpad-only?). 

Visit http://www.ryancollins.me/?p=1041. Tochpad-TAP (not click!) on one of the "Drop Down Parent" buttons or the two "Toggle Button" examples below. 


Actual results:

Nothing happens. 


Expected results:

The dropdown content (or toggled) content should appear. 

The examples work if you CLICK the touchpad instead of tapping it. It also works when double-tapping, however this also selects (parts) of the text. 

This fully works in Chrome (note: the missing transition in Fx is due to bad prefixed CSS).

Comment 1

[Florian Bender]

It also works as intended in Safari. -> Parity-webkit.

Comment 2

[Josiah Bruner [:jsbruner]]

Does it matter whether the user has enabled "tap to click" in settings?

Comment 3

[Florian Bender]

Sorry, forgot to add: You may need to enable "tap to click" in the system settings!

Comment 4

[Florian Bender]

Although I haven't tested it, disabling "tap to click" in the system settings should disable any tap functionality system-wide and thus should not lead to any registerable tap event.

Comment 5

[Josiah Bruner [:jsbruner]]

Yes, nothing happens when it is disabled on tap. But that is an expected result. This also happens on Firefox 18 and 19.

Comment 6

[Josiah Bruner [:jsbruner]]

This bug definitely seems to be related to CSS errors.

Comment 7

[Josiah Bruner [:jsbruner]]

It also occurs on Firefox 16.

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Curious to know how far back this goes - will affect our decision to track.

Comment 9

[Josiah Bruner [:jsbruner]]

I did a little testing and I can verify that the issue occurs at LEAST back to Firefox 12. I couldn't go any farther than that though. Firefox 11 keeps crashing on launch for me. If someone can test before Firefox 12 that would be great.

I wonder if this problem has always occurred, even on Firefox 1?

Comment 10

[Florian Bender]

This issue might not be a regression at all, but concerning the number of Mac clients (and possibly issues with Windows 8 laptops? -> needs investigation) this should be fixed. I know a lot of people who prefer tapping over clicking on this huge touchpad (BTW on my old MacBook my touchpad click was broken so I could only use tap to click – in Fx I would have not be able to use websites expecting such clicks resp. a tap to work like a click). People might think websites are broken in Fx when they don't react to user input (the tap) but they do in Webkit. 

Either way, tap should work like click on a trackpad/touchpad. 

So I guess this bug should change status to NEW and reproducible and it's Product: Core and Component: CSS or Layout?

Comment 11

[Alex Keybl [:akeybl]]

Given this is a longstanding issue, it doesn't meet the requirements for tracking for a specific version of Firefox. We only track critical issues and regressions, where a large percentage of our users are affected.

Comment 12

[Josiah Bruner [:jsbruner]]

Good to know. At first I wasn't aware of this being such a longstanding issue. Anyway, does this mean that we need to implement a whole new item, or is this issue a bug?

Comment 13

[Florian Bender]

From the UX perspective, this clearly is a bug. A tap on "legacy devices" should be treated as a click, especially concerning CSS.

Comment 14

[Florian Bender]

Please note that I'm not completely sure whether this is a CSS / :active issue or a tabindex issue or a (chrome) click event issue (or something else?)!

Comment 15

[Josiah Bruner [:jsbruner]]

If someone with greater knowledge than I could figure out what kind of an issue this is, that would be great. Seems like CSS to me, but I can not be sure. By the way, thanks for finding this Florian.

Comment 16

[u279076]

Is a regression window still desired here?

Comment 17

[Florian Bender]

Attachment: standalone testcase

As the linked URL is not available (at least for the moment), I created a standalone testcase. 

The issue still exist in Firefox 23 (on Mac OS X 10.8.4): A _tap_ does not produce the desired behaviour (but a _click_ or, to some extent, a double _tap_ does), whereas in current Chrome, it works as intended.

Comment 18

[u279076]

Juan, can you please try to track down a regression window? If this ends up being a regression please nominate it for tracking.

Comment 19

[juan becerra [:juanb]]

This doesn't work all the way back to Fx4.0.

It works on 3.6.28.

Comment 20

[juan becerra [:juanb]]

Well, it worked on 3.7a1 nightly from 2009-12-30 but not 2010-01-01:

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=35e6583db6ac&tochange=cb5a303025fe

I couldn't find anything obvious from the list, but there are several CSS fixes and some Mac specific fixes which could have something to do with this.

Comment 21

[u279076]

Thanks Juan, given how far back this goes I don't think we need to track for any branch at this point. It's still a valid bug which should be fixed, it's just not a critical issue which we regressed recently.

Comment 22

[Jonathan Watt [:jwatt]]

Mass bug change to replace various 'parity' whiteboard flags with the new canonical keywords. (See bug 1443764 comment 13.)