Closed Bug 806139 Opened 8 years ago Closed 8 years ago

Add "avc1.64001F" and "mp4v.20.3" to the list of supported h264 codecs, used by youtube

Categories

(Core :: Audio/Video, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: jbeich, Assigned: jbeich)

Details

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #761063 +++

YouTube seems to want "avc1.42001F" (h264 high 3.1) for 1080p/720p and "mp4v.20.3" (3gpp) for 240p videos. Here's an example, https://www.youtube.com/watch?v=hMDBwa4huUY . With media.webm.enabled -> false it lists for me "avc1.64001F, mp4a.40.2" (720p), "avc1.42001E, mp4a.40.2" (360p), "mp4v.20.3, mp4a.40.2" (240p) as available resolution options.
Attached patch patch (obsolete) — Splinter Review
Attachment #675900 - Flags: review?(chris.double)
(In reply to Jan Beich from comment #0)
> "avc1.42001F"

Obvious typo. Also, if bug 800600 lands first this bug can be marked as DUPLICATE.
Summary: Add "avc1.42001F" and "mp4v.20.3" to the list of supported h264 codecs, used by youtube → Add "avc1.64001F" and "mp4v.20.3" to the list of supported h264 codecs, used by youtube
Comment on attachment 675900 [details] [diff] [review]
patch

Review of attachment 675900 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/public/nsHTMLMediaElement.h
@@ +310,5 @@
>  #ifdef MOZ_GSTREAMER
>    static bool IsH264Enabled();
>    static bool IsH264Type(const nsACString& aType);
>    static const char gH264Types[3][16];
> +  static char const *const gH264Codecs[9];

You'll need to change this in the MOZ_WIDGET_GONK block below too. Or split this out into a block both defines share. r+ with that change.
Attachment #675900 - Flags: review?(chris.double) → review+
Attached patch patch, v2Splinter Review
Attachment #675900 - Attachment is obsolete: true
v2 stands for trivial changes (implicitly r+):

  #if defined(MOZ_GSTREAMER) || defined(MOZ_WIDGET_GONK)
    static char const *const gH264Codecs[9];
  #endif

making nsHTMLMediaElement.h and nsHTMLMediaElement.cpp both use same ifdef
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ed7fb37591cf
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.