Closed Bug 806144 Opened 8 years ago Closed 8 years ago
Script error in page Info .js with broken image
Steps to reproduce problem: 1. Load attachment 671645 [details] 2. Open Page Info 3. Switch to the Media tab Actual result: Error: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [imgIRequest.image] Source File: chrome://navigator/content/pageinfo/pageInfo.js Line: 1247
We only access imageRequest.image to access its numFrames. Sadly numFrames was removed over a year ago so the whole block is now useless. On trunk we can investigate porting bug 713889, but for the sake of the branches I have split the work into two halves, which is why this patch is just the minimal changes and does not do any potential code cleanup. To help simplify the second half of the work, I have also swapped the order of the mime type detection. The !isBG check is a random fix that I happened to notice at the same time.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #675904 - Flags: review?(iann_bugzilla)
Comment on attachment 675904 [details] [diff] [review] Proposed patch > var numFrames = 0; I presume this is still needed for the second half of the work?
Attachment #675904 - Flags: review?(iann_bugzilla) → review+
I didn't want to change code that the other patch will end up changing anyway.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.