806144 - JavaScript error in pageInfo.js with broken image

Status: RESOLVED FIXED

(SeaMonkey :: Page Info, defect)

Description

[[e-mail]]

Steps to reproduce problem:
1. Load attachment 671645 [details]
2. Open Page Info
3. Switch to the Media tab

Actual result:

Error: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [imgIRequest.image]
Source File: chrome://navigator/content/pageinfo/pageInfo.js
Line: 1247

Comment 1

[[e-mail]]

Attachment: Proposed patch

We only access imageRequest.image to access its numFrames. Sadly numFrames was removed over a year ago so the whole block is now useless. On trunk we can investigate porting bug 713889, but for the sake of the branches I have split the work into two halves, which is why this patch is just the minimal changes and does not do any potential code cleanup. To help simplify the second half of the work, I have also swapped the order of the mime type detection. The !isBG check is a random fix that I happened to notice at the same time.

Comment 2

[Philip Chee]

q.v. Bug 792735 Comment 13.

Comment 3

[Ian Neal]

Comment on attachment 675904 [details] [diff] [review]
Proposed patch

>   var numFrames = 0;
I presume this is still needed for the second half of the work?

Comment 4

[[e-mail]]

I didn't want to change code that the other patch will end up changing anyway.

Comment 5

[[e-mail]]

Pushed comm-central changeset 2204125b352d.

Comment 6

[[e-mail]]

Comment on attachment 675904 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): 491310
User impact if declined: JavaScript error in some cases
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch: None

Comment 7

[[e-mail]]

http://hg.mozilla.org/releases/comm-aurora/rev/ae6eff92c445
http://hg.mozilla.org/releases/comm-beta/rev/4666574fa596