Closed Bug 806168 Opened 11 years ago Closed 11 years ago

Add test for bug 802366 and bug 806127

Categories

(Core :: Storage: IndexedDB, defect)

Product:
Core
Component:
Storage: IndexedDB
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla19
Tracking Flags:
Tracking Status
firefox18 --- fixed
firefox19 --- fixed

People

(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)

References

Details

Attachments

(2 files)

Tests, v1
13.63 KB, patch
bent.mozilla
: review+
Details | Diff | Splinter Review
Epilogue: Remove extra indentation in webapp_clearBrowserData.js.
10.14 KB, patch
bent.mozilla
: review+
Details | Diff | Splinter Review 
I think this can be done by modifying the test added in bug 786295, although getting this to work is proving tricky because I don't understand anything about IndexedDB.
Assignee: nobody → justin.lebar+bug
Depends on: 802366, 806127
Attached patch Tests, v1 — — Splinter Review 

        Attachment #675968 -
        Flags: review?(bent.mozilla)

    
    

    
  


  
The extra indentaiton was necessary because we wanted hg/git to notice that webapp_clearBrowserData.js was actually a rename of test_webapp_clearBrowserData.html.

The only non-whitespace change here is removing the comment at the top of the file saying that we're going to make this change.

        Attachment #675969 -
        Flags: review?(bent.mozilla)

    
    

    
  
Comment on attachment 675968 [details] [diff] [review]
Tests, v1

Review of attachment 675968 [details] [diff] [review]:
-----------------------------------------------------------------

This looks great! Thanks!

        Attachment #675968 -
        Flags: review?(bent.mozilla) → review+

    
    

    
  
Comment on attachment 675969 [details] [diff] [review]
Epilogue: Remove extra indentation in webapp_clearBrowserData.js.

Review of attachment 675969 [details] [diff] [review]:
-----------------------------------------------------------------

Can you please add the creative commons license to this file too? Thanks!

        Attachment #675969 -
        Flags: review?(bent.mozilla) → review+

    
    

    
  
Landed on inbound; see bug 802366 comment 46.

    
    

    
  
Follow-up to disable this test on Android.

https://hg.mozilla.org/integration/mozilla-inbound/rev/8bc60d1ab725

The test I copied here was already disabled on Android, so this is nothing interesting.

    
    

    
  
And backed out for further orange; see bug 802366 comment 48.

    
    

    
  
Sorry, but this got caught up in the bug 802366 bustage and was backed out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/5dc1c0530b00

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/7bd8f1301fce
https://hg.mozilla.org/mozilla-central/rev/8ed3ac815205
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla19

    
  
Depends on: 819305

          You need to log in
          before you can comment on or make changes to this bug.