806184 - Can't use 'delete' method in WebIDL

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jan Varga [:janv]]

Attachment: quick fix

interface IDBObjectStoreSync {
  boolean delete (any key);
}

The code generator produces a method for this in IDBObjectStoreSyncBinding.cpp which doesn't compile since it conflicts with the C++ reserved word "delete"

Attaching a quick fix ...

Comment 1

[Vendelin Ruzicka [:vendo]]

Attachment: quick fix v.2

Same problem with c++ reserved word "continue".

interface IDBCursorSync {
  boolean continue(optional any key);
  boolean delete();
};

New version of quick fix added.

Comment 2

[Boris Zbarsky [:bzbarsky]]

I would prefer a method that takes the WebIDL identifier name and produces the name used in the binding code.  Then we can just call this method from the various places it's needed and update it as it becomes necessary....

Jan, Vendelin, are you actively working on this?

Comment 3

[Jan Varga [:janv]]

(In reply to Boris Zbarsky (:bz) from comment #2)
> I would prefer a method that takes the WebIDL identifier name and produces
> the name used in the binding code.  Then we can just call this method from
> the various places it's needed and update it as it becomes necessary....
> 
> Jan, Vendelin, are you actively working on this?

Yes, he needs this for bug 798875

Comment 4

[Vendelin Ruzicka [:vendo]]

Attachment: fix for c++ keywords v.3

I have created new attachment with fix and simple test. Any suggestions are welcome.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 676388 [details] [diff] [review]
fix for c++ keywords v.3

This doesn't seem to be a patch against tip, but against some intermediate state.  I'd really like to see a diff against tip.

Also, please drop the 'CG' from the class name, since this is not in fact a subclass of CGThing.

And add the missing newline to the end of TestCodeGen.webidl, please.

r=me with that.

Comment 6

[Vendelin Ruzicka [:vendo]]

Attachment: bug-806184-patch

New version of patch against tip added in attachment.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 676990 [details] [diff] [review]
bug-806184-patch

r=me

Comment 8

[Jan Varga [:janv]]

https://tbpl.mozilla.org/?tree=Try&rev=efe449d2ad7b

Comment 9

[Jan Varga [:janv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ea8a3b029079

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ea8a3b029079