806185 - Error: "caller is undefined" in ActivitiesService.jsm, line 305

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

STR:

1) Open the contacts app
2) click an existing contact
3) click on the message icon to write a new text message

You see the following error pop up:

Error: "caller is undefined" {file: "resource://gre/modules/ActivitiesService.jsm" line: 305}]

This is caused by this line:

http://hg.mozilla.org/mozilla-central/annotate/3621795c03e1/dom/activities/src/ActivitiesService.jsm#l246

I don't know what's the appropriate behavior here. Should we just return when (!caller)?

Comment 1

[[:fabrice] Fabrice Desré]

The SMS app does not specify "returnValue" for the "new" activity, so we bail out early at https://mxr.mozilla.org/mozilla-central/source/dom/activities/src/ActivitiesService.jsm#246

but then it sends a result at https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/js/sms.js#L1475

So my take is that:
1) we should return early when (!caller)
2) this means that the calling app is faulty, and we need to fix the sms app (either by adding "returnValue: true" in the manifest or by not doing a postResult)

Comment 2

[[:fabrice] Fabrice Desré]

Attachment: patch

I filed bug 806490 to get the sms app fixed. The gecko patch is enough to prevent errors, but the calling app may not receive what it expects.

Comment 3

[Gene Lian (I already quit Mozilla)]

Comment on attachment 676253 [details] [diff] [review]
patch

Review of attachment 676253 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/activities/src/ActivitiesService.jsm
@@ +294,1 @@
>        }

Cool! I'd prefer:

  if (!caller) {
    debug("!! caller is null for msg.id=" + msg.id);
    return;
  }

  obsData = JSON.stringify({ ... });

but have no strong opinion if you like the original one. :D

Comment 4

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/mozilla-inbound/rev/078e5c209552

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/078e5c209552

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8171318589ae