806190 - [sms][activity] don't switch back to thread list if we're already displaying the requested number

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

STR:

1) Open the Contacts app
2) Click on a contact
3) click on the message icon to write a new text message
4) repeat 1-3

Actual:

The activity is handled by the SMS app, switches back to the thread list and then back again to the specific conversation.

Expected:

The view should stay at the requested conversation and not unnecessarily switch back and forth

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6039

Pointer to Github pull-request

Comment 2

[Borja Salguero [:borjasalguero]]

I think that we should update this to b+ due to we would need to merge it in order to increase the performance (we save 2 transitions) and the user experience. Thanks [:ttaubert] for the tip!

Comment 3

[Borja Salguero [:borjasalguero]]

r+! Ready for mergin

Comment 4

[David Scravaglieri [:scravag]]

We don't want to take risk changing code at this stage. Stupid bug but it works.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 675937 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6039

[Approval Request Comment]
User impact if declined: Unnecessary flicker and transitions.
Risk to taking this patch (and alternatives if risky): Low risk, tiny patch.

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 675937 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6039

Setting r+ from :borjasalguero.

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://github.com/mozilla-b2g/gaia/commit/06a952c95040db6bb2ca0816d6430bdf9f1c92fb

Comment 8

[mlevin]

Actual result of "The view should stay at the requested conversation and not unnecessarily switch back and forth" is what happens on Unagi build 20130102070202.