Closed Bug 806209 Opened 7 years ago Closed 7 years ago

NS_StackWalk is not threadsafe

Categories

(Core :: Gecko Profiler, defect)

x86
Windows XP
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: neil, Assigned: ehsan)

Details

Attachments

(1 file)

The Gecko Profiler tries to use NS_StackWalk to get a backtrace on the suspended main thread. Unfortunately if the thread is suspended in fprintf then when NS_StackWalk tries to fprintf then the application deadlocks.
Yeah, we should make NS_StackWalk not printf.
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #676218 - Flags: review?(bgirard)
Thanks ehsan. Land it!
Attachment #676218 - Flags: review?(bgirard) → review+
https://hg.mozilla.org/mozilla-central/rev/3b340e47ccbc
https://hg.mozilla.org/mozilla-central/rev/26095585dc5b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.