806227 - Replace shortened forms of "don't" and "won't" with "do not" and "will not" in descriptions in Settings app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

1. Go to Settings -> Do Not Track.
2. "... that you don't want your behavior tracked" and "Turning on Do Not Track won't cause... "

While I was reading through our privacy policies and other About entries, I noticed we do not use shortened forms, i.e. we use "do not" instead of "don't".

We should replace "don't want" with "do not want" and "won't cause" with "will not cause".


===

My Git commit info currently shows:

2012-10-24 11:07:05
fcfa1857bed6596e992263206451c6814e4b2... (I see ellipsis at the end)

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

The same applies to "When it's on" in SIM security. It should be replaced by "When it is turned on" or "When it is on".

This is to ensure consistency throughout Firefox OS.

Comment 2

[David Scravaglieri [:scravag]]

Minusing but take care about Spanish an Portugese

Comment 3

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

https://github.com/mozilla-b2g/gaia/blob/588a3e02c4ace3b3341ba1f6bb7274120b53b2b3/apps/settings/elements/do_not_track.html#L38

still shows the shortened forms. Do we still want this?

Comment 4

[[e-mail]]

ni UX for feedback

Comment 5

[Jenny Lee]

The word change is fine. But I'd like to know is there a reason why we can't use shorten forms? Tks!

Comment 6

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(from comment #0)
> While I was reading through our privacy policies and other About entries, I
> noticed we do not use shortened forms, i.e. we use "do not" instead of
> "don't".

(In reply to Jenny Lee from comment #5)
> The word change is fine. But I'd like to know is there a reason why we can't
> use shorten forms? Tks!

For consistency? I don't have a strong opinion on this, but having our language to be consistent would be nice. Please feel free to close this if you think it is not needed or is not appropriate.

Comment 7

[Jenny Lee]

I'll check with content guide owner ;) Let's make the change for now. Thank you!

Comment 8

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to Jenny Lee from comment #7)
> I'll check with content guide owner ;) Let's make the change for now. Thank
> you!

Thanks! Fred, not sure what next needs to happen here, so setting needinfo?

Comment 9

[[e-mail]]

Let's flag it as good first bug :)
Any patch is welcome

Comment 10

[Manuel Casas Barrado [:mancas]]

Attachment: Replace shortened forms

Comment 11

[[e-mail]]

Comment on attachment 8453009 [details] [review]
Replace shortened forms

Thanks for the patch!

As our review rule, please set review to one of settings' module owner https://wiki.mozilla.org/Modules/FirefoxOS

(turn gary into feedback?)

Comment 12

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Comment on attachment 8453009 [details] [review]
Replace shortened forms

I'm :gkw, not tchung, so stealing feedback+. :)

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8453009 [details] [review]
Replace shortened forms

Thanks for the patch, Manuel!

The patch looks good. However, when changing strings, we should always change the l10n id at the same time so that the l10n team is able to aware the change. In this case "doNotTrack-dd1" could be altered with "doNotTrack-dd1_1" for example.

Comment 14

[Manuel Casas Barrado [:mancas]]

(In reply to Arthur Chen [:arthurcc] from comment #13)
> Comment on attachment 8453009 [details] [review]
> Replace shortened forms
> 
> Thanks for the patch, Manuel!
> 
> The patch looks good. However, when changing strings, we should always
> change the l10n id at the same time so that the l10n team is able to aware
> the change. In this case "doNotTrack-dd1" could be altered with
> "doNotTrack-dd1_1" for example.

Thanks for your comment Arthur. However, in that case the meaning of the sentence has not really changed so I don't think we need to modify the l10n id.

Comment 15

[Francesco Lodolo [:flod]]

Yes, no need to change ID in these cases.

Comment 16

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8453009 [details] [review]
Replace shortened forms

Delegating to our l10n team.

Comment 17

[Staś Małolepszy :stas]

Comment on attachment 8453009 [details] [review]
Replace shortened forms

When flod says it's okay, it's okay :) r=me, thanks for the patch!

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/76d9c1c1d1e56fcecd0b01ba604587cf73cb66aa

Comment 19

[Sue]

Attachment: video of issue verify

This issue has been verified successfully on Flame 2.1
See attachment: verify_video.MP4
Reproducing rate: 0/5
Flame 2.1 versions:
Gaia-Rev        1bdd49770e2cb7a7321e6202c9bf036ab5d8f200
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/db893274d9a6
Build-ID        20141125001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141125.040617
FW-Date         Tue Nov 25 04:06:28 EST 2014
Bootloader      L1TC00011880