Closed Bug 806227 Opened 7 years ago Closed 6 years ago

Replace shortened forms of "don't" and "won't" with "do not" and "will not" in descriptions in Settings app

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-basecamp:-, b2g-v2.1 verified)

VERIFIED FIXED
2.0 S6 (18july)
blocking-basecamp -
Tracking Status
b2g-v2.1 --- verified

People

(Reporter: gkw, Assigned: mancas)

References

Details

(Keywords: b2g-testdriver, unagi, Whiteboard: [good-first-bug][mentor=gasolin])

Attachments

(2 files)

1. Go to Settings -> Do Not Track.
2. "... that you don't want your behavior tracked" and "Turning on Do Not Track won't cause... "

While I was reading through our privacy policies and other About entries, I noticed we do not use shortened forms, i.e. we use "do not" instead of "don't".

We should replace "don't want" with "do not want" and "won't cause" with "will not cause".


===

My Git commit info currently shows:

2012-10-24 11:07:05
fcfa1857bed6596e992263206451c6814e4b2... (I see ellipsis at the end)
The same applies to "When it's on" in SIM security. It should be replaced by "When it is turned on" or "When it is on".

This is to ensure consistency throughout Firefox OS.
Summary: Replace shortened forms of "don't" and "won't" with "do not" and "will not" in Do Not Track description in Settings app → Replace shortened forms of "don't" and "won't" with "do not" and "will not" in descriptions in Settings app
Hardware: x86 → ARM
Minusing but take care about Spanish an Portugese
blocking-basecamp: ? → -
Component: Gaia → Gaia::Settings
No longer blocks: 950786
ni UX for feedback
Flags: needinfo?(jelee)
The word change is fine. But I'd like to know is there a reason why we can't use shorten forms? Tks!
Flags: needinfo?(jelee)
(from comment #0)
> While I was reading through our privacy policies and other About entries, I
> noticed we do not use shortened forms, i.e. we use "do not" instead of
> "don't".

(In reply to Jenny Lee from comment #5)
> The word change is fine. But I'd like to know is there a reason why we can't
> use shorten forms? Tks!

For consistency? I don't have a strong opinion on this, but having our language to be consistent would be nice. Please feel free to close this if you think it is not needed or is not appropriate.
Flags: needinfo?(jelee)
I'll check with content guide owner ;) Let's make the change for now. Thank you!
Flags: needinfo?(jelee)
(In reply to Jenny Lee from comment #7)
> I'll check with content guide owner ;) Let's make the change for now. Thank
> you!

Thanks! Fred, not sure what next needs to happen here, so setting needinfo?
Flags: needinfo?(gasolin)
Let's flag it as good first bug :)
Any patch is welcome
Flags: needinfo?(gasolin)
Whiteboard: [good-first-bug][mentor=gasolin]
Attachment #8453009 - Flags: review?(tchung)
Comment on attachment 8453009 [details] [review]
Replace shortened forms

Thanks for the patch!

As our review rule, please set review to one of settings' module owner https://wiki.mozilla.org/Modules/FirefoxOS

(turn gary into feedback?)
Attachment #8453009 - Flags: review?(tchung)
Attachment #8453009 - Flags: review?(arthur.chen)
Attachment #8453009 - Flags: feedback?(tchung)
Comment on attachment 8453009 [details] [review]
Replace shortened forms

I'm :gkw, not tchung, so stealing feedback+. :)
Attachment #8453009 - Flags: feedback?(tchung) → feedback+
Comment on attachment 8453009 [details] [review]
Replace shortened forms

Thanks for the patch, Manuel!

The patch looks good. However, when changing strings, we should always change the l10n id at the same time so that the l10n team is able to aware the change. In this case "doNotTrack-dd1" could be altered with "doNotTrack-dd1_1" for example.
Attachment #8453009 - Flags: review?(arthur.chen)
Assignee: nobody → b.mcb
(In reply to Arthur Chen [:arthurcc] from comment #13)
> Comment on attachment 8453009 [details] [review]
> Replace shortened forms
> 
> Thanks for the patch, Manuel!
> 
> The patch looks good. However, when changing strings, we should always
> change the l10n id at the same time so that the l10n team is able to aware
> the change. In this case "doNotTrack-dd1" could be altered with
> "doNotTrack-dd1_1" for example.

Thanks for your comment Arthur. However, in that case the meaning of the sentence has not really changed so I don't think we need to modify the l10n id.
Flags: needinfo?(francesco.lodolo)
Yes, no need to change ID in these cases.
Flags: needinfo?(francesco.lodolo)
Attachment #8453009 - Flags: review?(21)
Comment on attachment 8453009 [details] [review]
Replace shortened forms

Delegating to our l10n team.
Attachment #8453009 - Flags: review?(21) → review?(stas)
Comment on attachment 8453009 [details] [review]
Replace shortened forms

When flod says it's okay, it's okay :) r=me, thanks for the patch!
Attachment #8453009 - Flags: review?(stas) → review+
Master: https://github.com/mozilla-b2g/gaia/commit/76d9c1c1d1e56fcecd0b01ba604587cf73cb66aa
Status: NEW → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S6 (18july)
Attached video video of issue verify
This issue has been verified successfully on Flame 2.1
See attachment: verify_video.MP4
Reproducing rate: 0/5
Flame 2.1 versions:
Gaia-Rev        1bdd49770e2cb7a7321e6202c9bf036ab5d8f200
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/db893274d9a6
Build-ID        20141125001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141125.040617
FW-Date         Tue Nov 25 04:06:28 EST 2014
Bootloader      L1TC00011880
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.