806239 - Sending the dump-memory-reports-after-minimize signal results in two sets of reports

Status: RESOLVED FIXED

(Toolkit :: about:memory, defect)

Description

[Justin Lebar (not reading bugmail)]

I'm missing a return statement.

Comment 1

[Justin Lebar (not reading bugmail)]

Attachment: Patch, v1

Comment 2

[Justin Lebar (not reading bugmail)]

Comment on attachment 675986 [details] [diff] [review]
Patch, v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 800486

I know this isn't yet r+'ed, but I'm requesting approval anyway because this is a zero risk, brain-dead bug that I would like to get to B2G users as soon as possible, because it's keeping us from correctly getting memory reports off the device.

Comment 3

[Nicholas Nethercote [inactive]]

> [Approval Request Comment]
> Bug caused by (feature/regressing bug #): Bug 800486
> 
> I know this isn't yet r+'ed, but I'm requesting approval anyway because this
> is a zero risk, brain-dead bug that I would like to get to B2G users as soon
> as possible, because it's keeping us from correctly getting memory reports
> off the device.

I concur!  This should be on Aurora ASAP.

Comment 4

[Justin Lebar (not reading bugmail)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9e606320e6a5

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9e606320e6a5

Comment 6

[bhavana bajaj [:bajaj]]

Willing to approve this as soon as we have the risk assessment for desktop/mobile or a confirmation that the m-c bake time is good enough to notice any obvious regressions.Thanks !

Comment 7

[Justin Lebar (not reading bugmail)]

I indicated in comment 2 that this is a zero-risk bug.

Comment 8

[Justin Lebar (not reading bugmail)]

(In reply to Justin Lebar [:jlebar] from comment #7)
> I indicated in comment 2 that this is a zero-risk bug.

Or, a zero risk bug-fix, in any case.

Comment 9

[Justin Lebar (not reading bugmail)]

To elaborate: This code is not run unless you send a special signal from the operating system to Firefox.  We do this on B2G, and you can do it on Linux desktop too, if you want.  But nobody is doing it accidentally.  So this is a zero-risk fix to debugging-only code.

Comment 10

[bhavana bajaj [:bajaj]]

(In reply to Justin Lebar [:jlebar] from comment #9)
> To elaborate: This code is not run unless you send a special signal from the
> operating system to Firefox.  We do this on B2G, and you can do it on Linux
> desktop too, if you want.  But nobody is doing it accidentally.  So this is
> a zero-risk fix to debugging-only code.

Thanks for your quick response ! Patch is approved for aurora considering your comments

Comment 11

[Justin Lebar (not reading bugmail)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/df7645bd936c