Closed
Bug 806263
Opened 13 years ago
Closed 13 years ago
Move {Get,Set}ValueItemText up to MediaElement.
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: kinetik, Assigned: kinetik)
References
Details
Attachments
(1 file)
|
5.54 KB,
patch
|
cajbir
:
review+
|
Details | Diff | Splinter Review |
Bug 591467 added these to {Audio,Video}Element, but the implementation is identical, so it might as well exist on the MediaElement and save a tiny bit of code.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #676021 -
Flags: review?(chris.double)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 676021 [details] [diff] [review]
patch v0
Review of attachment 676021 [details] [diff] [review]:
-----------------------------------------------------------------
Do they need to be virtual? Are they overridden anywhere? r+ with or without virtual change.
Attachment #676021 -
Flags: review?(chris.double) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Yeah, they're called on a parent class.
https://hg.mozilla.org/integration/mozilla-inbound/rev/76515382c77f
|
||
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in
before you can comment on or make changes to this bug.
Description
•