80627 - <form>.elements.namedItem() returns NodeList instead of a single node

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andreas M. "Clarence" Schneider]

<form>.elements.namedItem() returns a NodeList (HTMLCollection). It should
return a single node.

DOM1 says in
http://www.w3.org/TR/2000/WD-DOM-Level-1-20000929/level-one-html.html#ID-75708506

namedItem
    This method retrieves a Node using a name. It first searches for a Node
    with a matching id attribute. If it doesn't find one, it then searches for
    a Node with a matching name attribute, but only on those elements that are
    allowed a name attribute.

namedItem() works as expected when used with document.images, but with
<form>.elements it behaves like document.getElementsByName().

Comment 1

[Andreas M. "Clarence" Schneider]

Attachment: testcase

Comment 2

[Andreas M. "Clarence" Schneider]

Additional note: This works, if only 1 element with the given name exists.

Nominating for 1.0. We should not introduce a wrong DOM with our product.

Comment 3

[Johnny Stenback (:jst)]

This patch fixes this problem.

Index: content/html/content/src/nsHTMLFormElement.cpp
===================================================================
RCS file: /cvsroot/mozilla/content/html/content/src/nsHTMLFormElement.cpp,v
retrieving revision 1.72
diff -u -r1.72 nsHTMLFormElement.cpp
--- nsHTMLFormElement.cpp       2001/05/08 16:44:47     1.72
+++ nsHTMLFormElement.cpp       2001/05/14 04:24:20
@@ -695,8 +695,8 @@

 // XPConnect interface list for nsFormControlList
 NS_CLASSINFO_MAP_BEGIN(HTMLFormControlCollection)
-  NS_CLASSINFO_MAP_ENTRY(nsIDOMNSHTMLFormControlList)
   NS_CLASSINFO_MAP_ENTRY(nsIDOMHTMLCollection)
+  NS_CLASSINFO_MAP_ENTRY(nsIDOMNSHTMLFormControlList)
 NS_CLASSINFO_MAP_END

Comment 4

[Fabian Guisset]

Tested the patch, it does fix the problem. Peter, want to r= ?

Comment 5

[Peter Van der Beken [:peterv]]

r=peterv.

Comment 6

[Prashant Desale]

Updating QA contact to Shivakiran Tummala.

Comment 7

[Johnny Stenback (:jst)]

Moving to mozilla0.9.3

Comment 8

[Fabian Guisset]

er come on let's get this in, this is getting silly (/me hates rotting patches)

Comment 9

[Johnny Stenback (:jst)]

No worries my friend, this will be fixed soon. :-)

Comment 10

[Johnny Stenback (:jst)]

This was fixed a while back, marking so...

Comment 11

[Andreas M. "Clarence" Schneider]

Yes, works with 2001-08-14-03, Win NT.