We don't measure NativeIterator objects pointed to by the private slot of PropertyIteratorObjects.
Created attachment 676048 [details] [diff] [review] Include native iterators in "object/misc" memory reports. This patch typically measures a few 100 KBs of NativeIterator objects, esp. in B2G profiles.
Do we want to split these out, so we have more visibility into where our memory is going?
Created attachment 676402 [details] [diff] [review] Split up and add native iterators to "object/misc" memory reports. This revised patch: - Splits up the "objects/misc" entry into three parts: "arguments-data", "regexp-statics", and "property-iterator-data". - Renames the "objects" sub-path as "objects-extra", to match "shapes-extra" (and better distinguish it from the "gc-heap/objects/*" reports).
Comment on attachment 676402 [details] [diff] [review] Split up and add native iterators to "object/misc" memory reports. [Approval Request Comment] Bug caused by (feature/regressing bug #): N/A User impact if declined: less insight into memory consumption for B2G. Testing completed (on m-c, etc.): landed on m-c today. Risk to taking this patch (and alternatives if risky): negligible; code only runs when about:memory is loaded or a memory report is triggered. String or UUID changes made by this patch: none.
https://hg.mozilla.org/releases/mozilla-aurora/rev/c0dfb00e3030 This required a bit of unbitrotting to apply to Aurora, but it was pretty mechanical. Probably wouldn't hurt to look it over as a sanity check, though.
Probably wouldn't hurt to look it over as a sanity check, though. > Looks ok to me. Thanks for uplifting it.