Include native iterators in "object/misc" memory reports.

RESOLVED FIXED in Firefox 18

Status

()

Product:
Core
Component:
JavaScript Engine
Type:
defect
Status:
RESOLVED FIXED
Reported:
7 years ago
Modified:
7 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

Version:
unspecified
Target:
mozilla19
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox18 fixed, firefox19 fixed)

Details

(Whiteboard: [MemShrink:P2])

Attachments

(1 attachment, 1 obsolete attachment)

Split up and add native iterators to "object/misc" memory reports.
15.42 KB, patch
jorendorff
: review+
bajaj
: approval-mozilla-aurora+
Details | Diff | Splinter Review
(Assignee)

Description

•
7 years ago 
We don't measure NativeIterator objects pointed to by the private slot of
PropertyIteratorObjects.
(Assignee)

Comment 1

•
7 years ago 
This patch typically measures a few 100 KBs of NativeIterator objects, esp. in
B2G profiles.
Attachment #676048 - Flags: review?(jorendorff)
 (Assignee)

Updated

•
7 years ago
Blocks: B2GDarkMatter
Whiteboard: [MemShrink]

Comment 2

•
7 years ago 
Do we want to split these out, so we have more visibility into where our memory is going?
 (Assignee)

Comment 3

•
7 years ago 
This revised patch: 

- Splits up the "objects/misc" entry into three parts: "arguments-data",
  "regexp-statics", and "property-iterator-data".  
  
- Renames the "objects" sub-path as "objects-extra", to match "shapes-extra"
  (and better distinguish it from the "gc-heap/objects/*" reports).
Attachment #676402 - Flags: review?(jorendorff)
 (Assignee)

Updated

•
7 years ago
Attachment #676048 - Attachment is obsolete: true
Attachment #676048 - Flags: review?(jorendorff)
 (Assignee)

Updated

•
7 years ago
Whiteboard: [MemShrink] → [MemShrink:P2]
Attachment #676402 - Flags: review?(jorendorff) → review+

Comment 5

•
7 years ago 
https://hg.mozilla.org/mozilla-central/rev/2f8306353ae9
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
 (Assignee)

Comment 6

•
7 years ago 
Comment on attachment 676402 [details] [diff] [review]
Split up and add native iterators to "object/misc" memory reports.

[Approval Request Comment]

Bug caused by (feature/regressing bug #):  N/A

User impact if declined: less insight into memory consumption for B2G.

Testing completed (on m-c, etc.): landed on m-c today.

Risk to taking this patch (and alternatives if risky): negligible;  code only runs when about:memory is loaded or a memory report is triggered. 

String or UUID changes made by this patch: none.
Attachment #676402 - Flags: approval-mozilla-aurora?
Attachment #676402 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 7

•
7 years ago 
https://hg.mozilla.org/releases/mozilla-aurora/rev/c0dfb00e3030

This required a bit of unbitrotting to apply to Aurora, but it was pretty mechanical. Probably wouldn't hurt to look it over as a sanity check, though.
status-firefox18: --- → fixed
status-firefox19: --- → fixed
 (Assignee)

Comment 8

•
7 years ago 
Probably wouldn't hurt to look it over as a sanity check, though.

> Looks ok to me.  Thanks for uplifting it.
You need to log in before you can comment on or make changes to this bug.