Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Include native iterators in "object/misc" memory reports.

RESOLVED FIXED in Firefox 18

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla19
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox18 fixed, firefox19 fixed)

Details

(Whiteboard: [MemShrink:P2])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
We don't measure NativeIterator objects pointed to by the private slot of
PropertyIteratorObjects.
(Assignee)

Comment 1

5 years ago
Created attachment 676048 [details] [diff] [review]
Include native iterators in "object/misc" memory reports.

This patch typically measures a few 100 KBs of NativeIterator objects, esp. in
B2G profiles.
Attachment #676048 - Flags: review?(jorendorff)
(Assignee)

Updated

5 years ago
Blocks: 798484
Whiteboard: [MemShrink]
Do we want to split these out, so we have more visibility into where our memory is going?
(Assignee)

Comment 3

5 years ago
Created attachment 676402 [details] [diff] [review]
Split up and add native iterators to "object/misc" memory reports.

This revised patch: 

- Splits up the "objects/misc" entry into three parts: "arguments-data",
  "regexp-statics", and "property-iterator-data".  
  
- Renames the "objects" sub-path as "objects-extra", to match "shapes-extra"
  (and better distinguish it from the "gc-heap/objects/*" reports).
Attachment #676402 - Flags: review?(jorendorff)
(Assignee)

Updated

5 years ago
Attachment #676048 - Attachment is obsolete: true
Attachment #676048 - Flags: review?(jorendorff)
(Assignee)

Updated

5 years ago
Whiteboard: [MemShrink] → [MemShrink:P2]
Attachment #676402 - Flags: review?(jorendorff) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f8306353ae9
https://hg.mozilla.org/mozilla-central/rev/2f8306353ae9
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
(Assignee)

Comment 6

5 years ago
Comment on attachment 676402 [details] [diff] [review]
Split up and add native iterators to "object/misc" memory reports.

[Approval Request Comment]

Bug caused by (feature/regressing bug #):  N/A

User impact if declined: less insight into memory consumption for B2G.

Testing completed (on m-c, etc.): landed on m-c today.

Risk to taking this patch (and alternatives if risky): negligible;  code only runs when about:memory is loaded or a memory report is triggered. 

String or UUID changes made by this patch: none.
Attachment #676402 - Flags: approval-mozilla-aurora?

Updated

5 years ago
Attachment #676402 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/c0dfb00e3030

This required a bit of unbitrotting to apply to Aurora, but it was pretty mechanical. Probably wouldn't hurt to look it over as a sanity check, though.
status-firefox18: --- → fixed
status-firefox19: --- → fixed
(Assignee)

Comment 8

5 years ago
Probably wouldn't hurt to look it over as a sanity check, though.

> Looks ok to me.  Thanks for uplifting it.
You need to log in before you can comment on or make changes to this bug.