Closed Bug 806283 Opened 13 years ago Closed 13 years ago

Include native iterators in "object/misc" memory reports.

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla19
Tracking Status
firefox18 --- fixed
firefox19 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

(Whiteboard: [MemShrink:P2])

Attachments

(1 file, 1 obsolete file)

We don't measure NativeIterator objects pointed to by the private slot of PropertyIteratorObjects.
This patch typically measures a few 100 KBs of NativeIterator objects, esp. in B2G profiles.
Attachment #676048 - Flags: review?(jorendorff)
Whiteboard: [MemShrink]
Do we want to split these out, so we have more visibility into where our memory is going?
This revised patch: - Splits up the "objects/misc" entry into three parts: "arguments-data", "regexp-statics", and "property-iterator-data". - Renames the "objects" sub-path as "objects-extra", to match "shapes-extra" (and better distinguish it from the "gc-heap/objects/*" reports).
Attachment #676402 - Flags: review?(jorendorff)
Attachment #676048 - Attachment is obsolete: true
Attachment #676048 - Flags: review?(jorendorff)
Whiteboard: [MemShrink] → [MemShrink:P2]
Attachment #676402 - Flags: review?(jorendorff) → review+
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Comment on attachment 676402 [details] [diff] [review] Split up and add native iterators to "object/misc" memory reports. [Approval Request Comment] Bug caused by (feature/regressing bug #): N/A User impact if declined: less insight into memory consumption for B2G. Testing completed (on m-c, etc.): landed on m-c today. Risk to taking this patch (and alternatives if risky): negligible; code only runs when about:memory is loaded or a memory report is triggered. String or UUID changes made by this patch: none.
Attachment #676402 - Flags: approval-mozilla-aurora?
Attachment #676402 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/c0dfb00e3030 This required a bit of unbitrotting to apply to Aurora, but it was pretty mechanical. Probably wouldn't hurt to look it over as a sanity check, though.
Probably wouldn't hurt to look it over as a sanity check, though. > Looks ok to me. Thanks for uplifting it.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: