80631 - incorrect --enable-optimize output from Unix Build Configurator

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Weylin Piegorsch]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux 2.4.4 i686; en-US; 0.8) Gecko/20010215
BuildID:    0.9



Reproducible: Always
Steps to Reproduce:
see additional information below

Actual Results:  see additional information below

Expected Results:  see additional information below

This is a problem with the compilation, hence the unusual information above.

I downloaded the mozilla 0.9 source, then followed the instruction to build from
http://www.mozilla.org/build.  One of these instructions said to generate a file
(~/.mozconfig) using the Unix Build Configurator.  On that page, I specified an
optimization setting of -O3 -mcpu=i686 -march=i686.  when I ran make -f
client.mk build, it would not complete, saying I had an invalid configuration
setup.  On further investigation, I discovered that make had incorrectly parsed
my optimization settings, treating each of my settings as it's own configuration
setting instead of the correct behavior (which was to treat them as optimization
settings -- note the difference).

This was easily fixed by placing double-quotation marks around my optimization
settings.  This should have been automatically done by the Unix Build Configurator.

Some System Info:

OS: Linux (from the LinuxFromScratch book, I think it was version 2.3.1)
make: Gnu make 3.79.1 (I am NOT using parallel builds)
libc: glibc 2.1

Comment 1

[rudman]

Leaf, this bug's for you, or for someone in your [metaphysical] neck of the woods...

Comment 2

[Daniel (Leaf) Nunes]

what output *did* you get? I get:

ac_add_options --enable-optimize=-O3 -mcpu=i686 -march=i686

which will not work, because there are spaces in the argument. I'm certain that 
using double-quotes around what you want passed to the compiler will work.

I'm not sure if the right fix is to assume that people won't quote arguments 
with spaces, and insert quotes for them, or let the user beware. cc'ing folks 
for feedback.

Comment 3

[Weylin Piegorsch]

Oops, sorry, meant to put that in.

input into text box on web page: -O3 -mcpu=i686 -march=i686
auto generation: ac_add_options --enable-optimize=-O3 -mcpu=i686 -march=i686
needed: ac_add_options --enable-optimize="-O3 -mcpu=i686 -march=i686"

I meant to put that in my original submision (sorry :)

A suggestion, maybe place a back-slash in front of any unquoted space? 
My 14-hour workdays don't allow me to look at the configuration-parsing
code, so I may be completely off base, but what about this for output:

ac_add_options --enable-optimize=-O3\ -mcpu=i686\ -march=i686

Comment 4

[Daniel (Leaf) Nunes]

that probably works; i'll have to peruse the other fields and see if they 
*require* unescaped spaces before trying to make that happen.

In the mean time, inputting quoted strings-with-spaces should workaround this.

Comment 5

[Jon Granrose]

workaround... punting out to focus on critical 0.9.4 bugs.

Comment 6

[Jon Granrose]

re-punt.  is this still a problem?

Comment 7

[Andreas Leuner]

yes, it is 

Comment 8

[Chase Phillips]

Attachment: selectively wrap ac values in double quotes in build.cgi

Comment 9

[Chase Phillips]

Comment on attachment 167468 [details] [diff] [review]
selectively wrap ac values in double quotes in build.cgi

Asking for review from bsmedberg.

Comment 10

[Chase Phillips]

[cmp@spruce build]$ cvs commit config.cgi
Checking in config.cgi;
/cvsroot/mozilla/webtools/build/config.cgi,v  <--  config.cgi
new revision: 1.44; previous revision: 1.43
done