806310 - "ASSERTION: canStoreInRuleTree must be false for inherited structs unless all properties have been specified with values other than inherit"

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: canStoreInRuleTree must be false for inherited structs unless all properties have been specified with values other than inherit: '!canStoreInRuleTree || aRuleDetail == eRuleFullReset || (aStartStruct && aRuleDetail == eRulePartialReset)', file layout/style/nsRuleNode.cpp, line 3555

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Boris Zbarsky [:bzbarsky]]

Hmm.  Looks like a regression from bug 804970.

In particular, CheckFontCallback changes full/partial reset RuleDetail values to the corresponding full/partial mixed values if IsRelativeLengthUnit(), which I assume is being hit here.  But we can in fact store those in the ruletree now, for rem.  So we should probably just check for em, not rem, in CheckFontCallback....  David?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Fix CheckFontCallback to match 'rem' unit changes. ()

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 680276 [details] [diff] [review]
Fix CheckFontCallback to match 'rem' unit changes.  ()

r=me

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/60df5b3e7137
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/98e22583895a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/60df5b3e7137
https://hg.mozilla.org/mozilla-central/rev/98e22583895a

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix rolled in to https://hg.mozilla.org/releases/mozilla-aurora/rev/1f9ef298ceeb